unittests: Pass a safely modifiable arg to QCoreApplication

samiraguiar · samiraguiar · commit d4215052dd4e · 2015-03-10T10:18:56.000+01:00
This also silents C++11 warning about deprecated conversion.
diff --git a/src/tests/TestImport.cpp b/src/tests/TestImport.cpp
@@ -15,12 +15,14 @@ TestImport::TestImport()
     // The app needs to be initialized for the utf8 test
     // to work
     argcount = 1;
-    args[0] = "sqlb-unittests";
+    args[0] = new char[20];
+    strcpy(args[0], "sqlb-unittests");
     app = new QCoreApplication(argcount, args);
 }
 
 TestImport::~TestImport()
 {
+    delete[] args[0];
     delete app;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -15,12 +15,14 @@ TestImport::TestImport()`
`15`	`15`	`// The app needs to be initialized for the utf8 test`
`16`	`16`	`// to work`
`17`	`17`	`argcount = 1;`
`18`		`- args[0] = "sqlb-unittests";`
	`18`	`+ args[0] = new char[20];`
	`19`	`+ strcpy(args[0], "sqlb-unittests");`
`19`	`20`	`app = new QCoreApplication(argcount, args);`
`20`	`21`	`}`
`21`	`22`
`22`	`23`	`TestImport::~TestImport()`
`23`	`24`	`{`
	`25`	`+ delete[] args[0];`
`24`	`26`	`delete app;`
`25`	`27`	`}`
`26`	`28`