Clear the tree widget in the Structure tab when after closing a DB

MKleusberg · rp- · commit 244d811adc3d · 2014-04-28T20:53:37.000+02:00
Clear the tree widget in the 'Database Structure' tab of the main window after closing a database. See issue sqlitebrowser#44.
diff --git a/src/DbStructureModel.cpp b/src/DbStructureModel.cpp
@@ -122,6 +122,13 @@ void DbStructureModel::reloadData(DBBrowserDB* db)
         rootItem->removeChild(rootItem->child(0));
     }
 
+    // Return here if no DB is opened
+    if(!db->isOpen())
+    {
+        endResetModel();
+        return;
+    }
+
     // Create the nodes for tables, indices, views and triggers
     QMap<QString, QTreeWidgetItem*> typeToParentItem;
     QTreeWidgetItem* itemTables = new QTreeWidgetItem(rootItem);
diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
@@ -224,10 +224,15 @@ void MainWindow::populateStructure()
 {
     completerModelTables.clear();
     clearCompleterModelsFields();
+
+    // Refresh the structure tab
+    db.updateSchema();
+    dbStructureModel->reloadData(&db);
+    ui->dbTreeWidget->expandToDepth(0);
+
     if(!db.isOpen())
         return;
 
-    db.updateSchema();
     QStringList tblnames = db.getBrowsableObjectNames();
     sqliteHighlighterLogUser->setTableNames(tblnames);
     sqliteHighlighterLogApp->setTableNames(tblnames);
@@ -271,10 +276,6 @@ void MainWindow::populateStructure()
         sqlarea->getEditor()->setDefaultCompleterModel(&completerModelTables);
         sqlarea->getEditor()->insertFieldCompleterModels(completerModelsFields);
     }
-
-    // Refresh the structure tab
-    dbStructureModel->reloadData(&db);
-    ui->dbTreeWidget->expandToDepth(0);
 }
 
 void MainWindow::populateTable( const QString & tablename)
diff --git a/src/sqlitedb.cpp b/src/sqlitedb.cpp
@@ -756,10 +756,14 @@ void DBBrowserDB::updateSchema( )
     sqlite3_stmt *vm;
     const char *tail;
     int err=0;
+    lastErrorMessage = QObject::tr("no error");
 
     objMap.clear();
 
-    lastErrorMessage = QObject::tr("no error");
+    // Exit here is no DB is opened
+    if(!isOpen())
+        return;
+
     QString statement = "SELECT type, name, sql, tbl_name FROM sqlite_master;";
 
     QByteArray utf8Statement = statement.toUtf8();
