illegal global id should yield illegal argument exception

Jiayu Liu · dminkovsky · commit 662ec104dfe7 · 2016-10-26T12:04:11.000-04:00
diff --git a/src/main/java/graphql/relay/Relay.java b/src/main/java/graphql/relay/Relay.java
@@ -212,6 +212,9 @@ public String toGlobalId(String type, String id) {
 
     public ResolvedGlobalId fromGlobalId(String globalId) {
         String[] split = Base64.fromBase64(globalId).split(":", 2);
+        if (split.length != 2) {
+            throw new IllegalArgumentException(String.format("expecting a valid global id, got %s", globalId));
+        }
         return new ResolvedGlobalId(split[0], split[1]);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,9 @@ public String toGlobalId(String type, String id) {`
`212`	`212`
`213`	`213`	`public ResolvedGlobalId fromGlobalId(String globalId) {`
`214`	`214`	`String[] split = Base64.fromBase64(globalId).split(":", 2);`
	`215`	`+ if (split.length != 2) {`
	`216`	`+ throw new IllegalArgumentException(String.format("expecting a valid global id, got %s", globalId));`
	`217`	`+ }`
`215`	`218`	`return new ResolvedGlobalId(split[0], split[1]);`
`216`	`219`	`}`
`217`	`220`	`}`