change coerceValue to parseValue (inspired by the js impl)

andimarek · andimarek · commit 60d48acd7fab · 2016-01-17T16:35:55.000+01:00
diff --git a/src/main/java/graphql/Scalars.java b/src/main/java/graphql/Scalars.java
@@ -24,7 +24,7 @@ public Object coerce(Object input) {
         }
 
         @Override
-        public Object coerceValue(Object input) {
+        public Object parseValue(Object input) {
             return null;
         }
 
@@ -51,7 +51,7 @@ public Object coerce(Object input) {
         }
 
         @Override
-        public Object coerceValue(Object input) {
+        public Object parseValue(Object input) {
             return null;
         }
 
@@ -75,7 +75,7 @@ public Object coerce(Object input) {
         }
 
         @Override
-        public Object coerceValue(Object input) {
+        public Object parseValue(Object input) {
             return null;
         }
 
@@ -92,7 +92,7 @@ public Object coerce(Object input) {
         }
 
         @Override
-        public Object coerceValue(Object input) {
+        public Object parseValue(Object input) {
             return null;
         }
 
@@ -119,7 +119,7 @@ public Object coerce(Object input) {
         }
 
         @Override
-        public Object coerceValue(Object input) {
+        public Object parseValue(Object input) {
             return null;
         }
 
@@ -142,7 +142,7 @@ public Object coerce(Object input) {
         }
 
         @Override
-        public Object coerceValue(Object input) {
+        public Object parseValue(Object input) {
             return null;
         }
 
diff --git a/src/main/java/graphql/execution/ValuesResolver.java b/src/main/java/graphql/execution/ValuesResolver.java
@@ -93,7 +93,7 @@ private Object coerceValueForScalar(GraphQLScalarType graphQLScalarType, Object
     }
 
     private Object coerceValueForEnum(GraphQLEnumType graphQLEnumType, Object value) {
-        return graphQLEnumType.getCoercing().coerceValue(value);
+        return graphQLEnumType.getCoercing().parseValue(value);
     }
 
     private List coerceValueForList(GraphQLList graphQLList, Object value) {
diff --git a/src/main/java/graphql/schema/Coercing.java b/src/main/java/graphql/schema/Coercing.java
@@ -4,9 +4,19 @@
 public interface Coercing {
 
 
+    /**
+     * @param input
+     * @return
+     */
     Object coerce(Object input);
 
-    Object coerceValue(Object input);
+    /**
+     * Called to resolve a input from a variable.
+     *
+     * @param input
+     * @return
+     */
+    Object parseValue(Object input);
 
     /**
      * @param input
diff --git a/src/main/java/graphql/schema/GraphQLEnumType.java b/src/main/java/graphql/schema/GraphQLEnumType.java
@@ -24,7 +24,7 @@ public Object coerce(Object input) {
         }
 
         @Override
-        public Object coerceValue(Object input) {
+        public Object parseValue(Object input) {
             return getValueByName(input);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public Object coerce(Object input) {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`@Override`
`27`		`- public Object coerceValue(Object input) {`
	`27`	`+ public Object parseValue(Object input) {`
`28`	`28`	`return null;`
`29`	`29`	`}`
`30`	`30`
`@@ -51,7 +51,7 @@ public Object coerce(Object input) {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`@Override`
`54`		`- public Object coerceValue(Object input) {`
	`54`	`+ public Object parseValue(Object input) {`
`55`	`55`	`return null;`
`56`	`56`	`}`
`57`	`57`
`@@ -75,7 +75,7 @@ public Object coerce(Object input) {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`@Override`
`78`		`- public Object coerceValue(Object input) {`
	`78`	`+ public Object parseValue(Object input) {`
`79`	`79`	`return null;`
`80`	`80`	`}`
`81`	`81`
`@@ -92,7 +92,7 @@ public Object coerce(Object input) {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`@Override`
`95`		`- public Object coerceValue(Object input) {`
	`95`	`+ public Object parseValue(Object input) {`
`96`	`96`	`return null;`
`97`	`97`	`}`
`98`	`98`
`@@ -119,7 +119,7 @@ public Object coerce(Object input) {`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`@Override`
`122`		`- public Object coerceValue(Object input) {`
	`122`	`+ public Object parseValue(Object input) {`
`123`	`123`	`return null;`
`124`	`124`	`}`
`125`	`125`
`@@ -142,7 +142,7 @@ public Object coerce(Object input) {`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`@Override`
`145`		`- public Object coerceValue(Object input) {`
	`145`	`+ public Object parseValue(Object input) {`
`146`	`146`	`return null;`
`147`	`147`	`}`
`148`	`148`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ private Object coerceValueForScalar(GraphQLScalarType graphQLScalarType, Object`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`private Object coerceValueForEnum(GraphQLEnumType graphQLEnumType, Object value) {`
`96`		`- return graphQLEnumType.getCoercing().coerceValue(value);`
	`96`	`+ return graphQLEnumType.getCoercing().parseValue(value);`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`private List coerceValueForList(GraphQLList graphQLList, Object value) {`