Added help notes

mitchheddles · mitchheddles · commit d8cd9fb1e151 · 2018-05-18T11:14:02.000+10:00
diff --git a/generate/scripts/helpers.js b/generate/scripts/helpers.js
@@ -85,7 +85,8 @@ var Helpers = {
   },
 
   isCallbackFunction: function(cType) {
-    // TODO: Fix this
+    // NOTE: Added this just to get it working, I'm not sure how else to get
+    // around this, as the fieldOverrides are applied after this.
     if (cType === 'git_push_transfer_progress') {
       return true;
     }
diff --git a/test/tests/remote.js b/test/tests/remote.js
@@ -133,6 +133,9 @@ describe("Remote", function() {
     var repo = this.repository;
     var wasCalled = false;
 
+    // NOTE: This doesn't work, the credentials callback fails.
+    // Did manage to get it working by setting up a local bare repo and pushing to it.
+
     return Remote.create(repo, "test2", url2)
       .then(function(remote) {
         var fetchOpts = {

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,8 @@ var Helpers = {`
`85`	`85`	`},`
`86`	`86`
`87`	`87`	`isCallbackFunction: function(cType) {`
`88`		`- // TODO: Fix this`
	`88`	`+ // NOTE: Added this just to get it working, I'm not sure how else to get`
	`89`	`+ // around this, as the fieldOverrides are applied after this.`
`89`	`90`	`if (cType === 'git_push_transfer_progress') {`
`90`	`91`	`return true;`
`91`	`92`	`}`