Skip to content

Commit 382bedb

Browse files
implausibleemmax86
implausible
authored and
emmax86
committed
Bump fs-extra to get rid of most promisify calls in nodegit
1 parent 579eb98 commit 382bedb

34 files changed

Lines changed: 101 additions & 135 deletions

‎examples/add-and-commit.js‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
var nodegit = require("../");
22
var path = require("path");
3-
var promisify = require("promisify-node");
4-
var fse = promisify(require("fs-extra"));
3+
var fse = require("fs-extra");
54
var fileName = "newfile.txt";
65
var fileContent = "hello world";
76
var directoryName = "salad/toast/strangerinastrangeland/theresnowaythisexists";
8-
// ensureDir is an alias to mkdirp, which has the callback with a weird name
9-
// and in the 3rd position of 4 (the 4th being used for recursion). We have to
10-
// force promisify it, because promisify-node won't detect it on its
11-
// own and assumes sync
12-
fse.ensureDir = promisify(fse.ensureDir);
137

148
/**
159
* This example creates a certain file `newfile.txt`, adds it to the git

‎examples/clone.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
var nodegit = require("../");
2-
var promisify = require("promisify-node");
3-
var fse = promisify(require("fs-extra"));
2+
var fse = require("fs-extra");
43
var path = "/tmp/nodegit-clone-demo";
54

65
fse.remove(path).then(function() {

‎examples/cloneFromGithubWith2Factor.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
var nodegit = require("../");
2-
var promisify = require("promisify-node");
3-
var fse = promisify(require("fs-extra"));
2+
var fse = require("fs-extra");
43
var path = "/tmp/nodegit-github-2factor-demo";
54

65
var token = "{Your GitHub user token}";

‎examples/create-new-repo.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
var nodegit = require("../");
22
var path = require("path");
3-
var promisify = require("promisify-node");
4-
var fse = promisify(require("fs-extra"));
3+
var fse = require("fs-extra");
54
var fileName = "newfile.txt";
65
var fileContent = "hello world";
76
var repoDir = "../../newRepo";
87

9-
fse.ensureDir = promisify(fse.ensureDir);
10-
118
var repository;
129
var index;
1310

‎examples/index-add-and-remove.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
var nodegit = require("../");
22
var path = require("path");
3-
var promisify = require("promisify-node");
4-
var fse = promisify(require("fs-extra"));
3+
var fse = require("fs-extra");
54

65
nodegit.Repository.open(path.resolve(__dirname, "../.git"))
76
.then(function(repo) {

‎examples/merge-cleanly.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
var nodegit = require("../");
22
var path = require("path");
3-
var promisify = require("promisify-node");
4-
var fse = promisify(require("fs-extra"));
5-
fse.ensureDir = promisify(fse.ensureDir);
3+
var fse = require("fs-extra");
64

75
var ourFileName = "ourNewFile.txt";
86
var ourFileContent = "I like Toll Roads. I have an EZ-Pass!";

‎examples/merge-with-conflicts.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
var nodegit = require("../");
22
var path = require("path");
3-
var promisify = require("promisify-node");
4-
var fse = promisify(require("fs-extra"));
5-
fse.ensureDir = promisify(fse.ensureDir);
3+
var fse = require("fs-extra");
64

75
var repoDir = "../../newRepo";
86
var fileName = "newFile.txt";

‎examples/push.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
var nodegit = require("../");
22
var path = require("path");
3-
var promisify = require("promisify-node");
4-
var fse = promisify(require("fs-extra"));
5-
fse.ensureDir = promisify(fse.ensureDir);
3+
var fse = require("fs-extra");
64

75
var fileName = "newFile.txt";
86
var fileContent = "hello world";

‎generate/scripts/generateNativeCode.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const path = require("path");
2-
const promisify = require("promisify-node");
3-
const fse = promisify(require("fs-extra"));
2+
const fse = require("fs-extra");
43
const os = require('os');
54
const exec = require('../../utils/execPromise');
65
const utils = require("./utils");

‎lib/repository.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
var promisify = require("promisify-node");
2-
var fse = promisify(require("fs-extra"));
1+
var fse = require("fs-extra");
32
var fp = require("lodash/fp");
43
var NodeGit = require("../");
54
var Blob = NodeGit.Blob;

0 commit comments

Comments
 (0)