No longer mark multiple arguments as isSelf

smith-kyle · smith-kyle · commit 13c633665257 · 2015-11-26T12:27:01.000-07:00
The old isSelf condition didn't account for cases like .compare or
.equal
diff --git a/generate/scripts/helpers.js b/generate/scripts/helpers.js
@@ -262,7 +262,9 @@ var Helpers = {
       // itself and determine if this function goes on the prototype
       // or is a constructor method.
       arg.isReturn = arg.name === "out" || (utils.isDoublePointer(arg.type) && normalizedType == typeDef.cType);
-      arg.isSelf = utils.isPointer(arg.type) && normalizedType == typeDef.cType;
+      arg.isSelf = utils.isPointer(arg.type) &&
+        normalizedType == typeDef.cType &&
+        _.every(allArgs, function(_arg) { return !_arg.isSelf; });
 
       if (arg.isReturn && fnDef.return && fnDef.return.type === "int") {
         fnDef.return.isErrorCode = true;
