Skip to content

Commit cfdccd5

Browse files
AlexKValAlexKVal
committed
Encourage usage of just 'attrName' instead of 'attrName={true}'
for boolean attributes via examples to cultivate more clean code
1 parent f0d65c1 commit cfdccd5

13 files changed

+19
-19
lines changed

‎docs/examples/DropdownButtonBasic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function renderDropdownButton (title, i) {
55
<DropdownButton bsStyle={title.toLowerCase()} title={title} key={i}>
66
<MenuItem eventKey='1'>Action</MenuItem>
77
<MenuItem eventKey='2'>Another action</MenuItem>
8-
<MenuItem eventKey='3' active={true}>Active Item</MenuItem>
8+
<MenuItem eventKey='3' active>Active Item</MenuItem>
99
<MenuItem divider />
1010
<MenuItem eventKey='4'>Separated link</MenuItem>
1111
</DropdownButton>

‎docs/examples/NavBasic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const navInstance = (
66
<Nav bsStyle='pills' activeKey={1} onSelect={handleSelect}>
77
<NavItem eventKey={1} href='/home'>NavItem 1 content</NavItem>
88
<NavItem eventKey={2} title='Item'>NavItem 2 content</NavItem>
9-
<NavItem eventKey={3} disabled={true}>NavItem 3 content</NavItem>
9+
<NavItem eventKey={3} disabled>NavItem 3 content</NavItem>
1010
</Nav>
1111
);
1212

‎docs/examples/NavDropdown.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ const NavDropdown = React.createClass({
88
<Nav bsStyle='tabs' activeKey={1} onSelect={this.handleSelect}>
99
<NavItem eventKey={1} href='/home'>NavItem 1 content</NavItem>
1010
<NavItem eventKey={2} title='Item'>NavItem 2 content</NavItem>
11-
<NavItem eventKey={3} disabled={true}>NavItem 3 content</NavItem>
12-
<DropdownButton eventKey={4} title='Dropdown' navItem={true}>
11+
<NavItem eventKey={3} disabled>NavItem 3 content</NavItem>
12+
<DropdownButton eventKey={4} title='Dropdown' navItem>
1313
<MenuItem eventKey='4.1'>Action</MenuItem>
1414
<MenuItem eventKey='4.2'>Another action</MenuItem>
1515
<MenuItem eventKey='4.3'>Something else here</MenuItem>

‎docs/examples/NavJustified.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ const NavJustified = React.createClass({
99
<Nav bsStyle='tabs' justified activeKey={1} onSelect={this.handleSelect}>
1010
<NavItem eventKey={1} href='/home'>NavItem 1 content</NavItem>
1111
<NavItem eventKey={2} title='Item'>NavItem 2 content</NavItem>
12-
<NavItem eventKey={3} disabled={true}>NavItem 3 content</NavItem>
12+
<NavItem eventKey={3} disabled>NavItem 3 content</NavItem>
1313
</Nav>
1414
<br />
1515
<Nav bsStyle='pills' justified activeKey={1} onSelect={this.handleSelect}>
1616
<NavItem eventKey={1} href='/home'>NavItem 1 content</NavItem>
1717
<NavItem eventKey={2} title='Item'>NavItem 2 content</NavItem>
18-
<NavItem eventKey={3} disabled={true}>NavItem 3 content</NavItem>
18+
<NavItem eventKey={3} disabled>NavItem 3 content</NavItem>
1919
</Nav>
2020
</div>
2121
);

‎docs/examples/NavStacked.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const navInstance = (
66
<Nav bsStyle='pills' stacked activeKey={1} onSelect={handleSelect}>
77
<NavItem eventKey={1} href='/home'>NavItem 1 content</NavItem>
88
<NavItem eventKey={2} title='Item'>NavItem 2 content</NavItem>
9-
<NavItem eventKey={3} disabled={true}>NavItem 3 content</NavItem>
9+
<NavItem eventKey={3} disabled>NavItem 3 content</NavItem>
1010
</Nav>
1111
);
1212

‎docs/examples/PaginationAdvanced.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ const PaginationAdvanced = React.createClass({
1414
render() {
1515
return (
1616
<Pagination
17-
prev={true}
18-
next={true}
19-
first={true}
20-
last={true}
21-
ellipsis={true}
17+
prev
18+
next
19+
first
20+
last
21+
ellipsis
2222
items={20}
2323
maxButtons={5}
2424
activePage={this.state.activePage}

‎docs/examples/PopoverTriggerBehaviors.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const positionerInstance = (
99
<OverlayTrigger trigger='focus' placement='bottom' overlay={<Popover title='Popover bottom'><strong>Holy guacamole!</strong> Check this info.</Popover>}>
1010
<Button bsStyle='default'>Focus</Button>
1111
</OverlayTrigger>
12-
<OverlayTrigger trigger='click' rootClose={true} placement='bottom' overlay={<Popover title='Popover bottom'><strong>Holy guacamole!</strong> Check this info.</Popover>}>
12+
<OverlayTrigger trigger='click' rootClose placement='bottom' overlay={<Popover title='Popover bottom'><strong>Holy guacamole!</strong> Check this info.</Popover>}>
1313
<Button bsStyle='default'>Click + rootClose</Button>
1414
</OverlayTrigger>
1515
</ButtonToolbar>

‎docs/examples/TabbedAreaControlled.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const ControlledTabArea = React.createClass({
1515
<TabbedArea activeKey={this.state.key} onSelect={this.handleSelect}>
1616
<TabPane eventKey={1} tab='Tab 1'>TabPane 1 content</TabPane>
1717
<TabPane eventKey={2} tab='Tab 2'>TabPane 2 content</TabPane>
18-
<TabPane eventKey={3} tab='Tab 3' disabled={true}>TabPane 3 content</TabPane>
18+
<TabPane eventKey={3} tab='Tab 3' disabled>TabPane 3 content</TabPane>
1919
</TabbedArea>
2020
);
2121
}

‎docs/examples/TabbedAreaNoAnimation.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const tabbedAreaInstance = (
22
<TabbedArea defaultActiveKey={1} animation={false}>
33
<TabPane eventKey={1} tab='Tab 1'>TabPane 1 content</TabPane>
44
<TabPane eventKey={2} tab='Tab 2'>TabPane 2 content</TabPane>
5-
<TabPane eventKey={3} tab='Tab 3' disabled={true}>TabPane 3 content</TabPane>
5+
<TabPane eventKey={3} tab='Tab 3' disabled>TabPane 3 content</TabPane>
66
</TabbedArea>
77
);
88

‎docs/examples/TabbedAreaUncontrolled.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const tabbedAreaInstance = (
22
<TabbedArea defaultActiveKey={2}>
33
<TabPane eventKey={1} tab='Tab 1'>TabPane 1 content</TabPane>
44
<TabPane eventKey={2} tab='Tab 2'>TabPane 2 content</TabPane>
5-
<TabPane eventKey={3} tab='Tab 3' disabled={true}>TabPane 3 content</TabPane>
5+
<TabPane eventKey={3} tab='Tab 3' disabled>TabPane 3 content</TabPane>
66
</TabbedArea>
77
);
88

0 commit comments

Comments
 (0)