Impose 'space-before-function-paren'

AlexKVal · AlexKVal · commit 6c107d178f6a · 2015-09-03T14:49:17.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -30,7 +30,6 @@
     "react/jsx-no-duplicate-props": 2,
     "react/prop-types": [2, { "ignore": [ "children", "className", "style" ] }],
     "react/sort-comp": 0,
-    "space-before-function-paren": 0,
     "spaced-comment": 0,
     "vars-on-top": 0
   }
diff --git a/docs/examples/DropdownButtonBasic.js b/docs/examples/DropdownButtonBasic.js
@@ -1,6 +1,6 @@
 const BUTTONS = ['Default', 'Primary', 'Success', 'Info', 'Warning', 'Danger', 'Link'];
 
-function renderDropdownButton (title, i) {
+function renderDropdownButton(title, i) {
   return (
     <DropdownButton bsStyle={title.toLowerCase()} title={title} key={i} id={`dropdown-basic-${i}`}>
       <MenuItem eventKey="1">Action</MenuItem>
diff --git a/docs/examples/ListGroupLinked.js b/docs/examples/ListGroupLinked.js
@@ -1,4 +1,4 @@
-function alertClicked () {
+function alertClicked() {
   alert('You clicked the third ListGroupItem');
 }
 
diff --git a/docs/examples/NavBasic.js b/docs/examples/NavBasic.js
@@ -1,4 +1,4 @@
-function handleSelect (selectedKey) {
+function handleSelect(selectedKey) {
   alert('selected ' + selectedKey);
 }
 
diff --git a/docs/examples/NavStacked.js b/docs/examples/NavStacked.js
@@ -1,4 +1,4 @@
-function handleSelect (selectedKey) {
+function handleSelect(selectedKey) {
   alert('selected ' + selectedKey);
 }
 
diff --git a/docs/examples/SplitButtonBasic.js b/docs/examples/SplitButtonBasic.js
@@ -1,6 +1,6 @@
 const BUTTONS = ['Default', 'Primary', 'Success', 'Info', 'Warning', 'Danger'];
 
-function renderDropdownButton (title, i) {
+function renderDropdownButton(title, i) {
   return (
     <SplitButton bsStyle={title.toLowerCase()} title={title} key={i} id={`split-button-basic-${i}`}>
       <MenuItem eventKey="1">Action</MenuItem>
diff --git a/docs/server.js b/docs/server.js
@@ -21,7 +21,7 @@ if (development) {
   let webpackPort = process.env.WEBPACK_DEV_PORT;
   let target = `http://${ip.address()}:${webpackPort}`;
 
-  app.get('/assets/*', function (req, res) {
+  app.get('/assets/*', function(req, res) {
     proxy.web(req, res, { target });
   });
 
@@ -49,7 +49,7 @@ if (development) {
   app.use(express.static(path.join(__dirname, '../docs-built')));
 }
 
-app.listen(port, function () {
+app.listen(port, function() {
   console.log(`Server started at:`);
   console.log(`- http://localhost:${port}`);
   console.log(`- http://${ip.address()}:${port}`);
diff --git a/karma.conf.js b/karma.conf.js
@@ -18,7 +18,7 @@ if (runCoverage) {
   }
 }
 
-module.exports = function (config) {
+module.exports = function(config) {
   config.set({
 
     basePath: '',
diff --git a/src/Col.js b/src/Col.js
@@ -149,7 +149,7 @@ const Col = React.createClass({
     let ComponentClass = this.props.componentClass;
     let classes = {};
 
-    Object.keys(styleMaps.SIZES).forEach(function (key) {
+    Object.keys(styleMaps.SIZES).forEach(function(key) {
       let size = styleMaps.SIZES[key];
       let prop = size;
       let classPart = size + '-';
diff --git a/src/FadeMixin.js b/src/FadeMixin.js
@@ -3,7 +3,7 @@ import domUtils from './utils/domUtils';
 import deprecationWarning from './utils/deprecationWarning';
 
 // TODO: listen for onTransitionEnd to remove el
-function getElementsAndSelf (root, classes) {
+function getElementsAndSelf(root, classes) {
   let els = root.querySelectorAll('.' + classes.join('.'));
 
   els = [].map.call(els, function(e) { return e; });
@@ -29,7 +29,7 @@ export default {
       els = getElementsAndSelf(React.findDOMNode(this), ['fade']);
 
       if (els.length) {
-        els.forEach(function (el) {
+        els.forEach(function(el) {
           el.className += ' in';
         });
       }
@@ -40,7 +40,7 @@ export default {
     let els = getElementsAndSelf(this._fadeOutEl, ['fade', 'in']);
 
     if (els.length) {
-      els.forEach(function (el) {
+      els.forEach(function(el) {
         el.className = el.className.replace(/\bin\b/, '');
       });
     }
diff --git a/src/FormGroup.js b/src/FormGroup.js
@@ -29,7 +29,7 @@ FormGroup.defaultProps = {
 FormGroup.propTypes = {
   standalone: React.PropTypes.bool,
   hasFeedback: React.PropTypes.bool,
-  bsSize (props) {
+  bsSize(props) {
     if (props.standalone && props.bsSize !== undefined) {
       return new Error('bsSize will not be used when `standalone` is set.');
     }
diff --git a/src/Modal.js b/src/Modal.js
@@ -406,8 +406,8 @@ const Modal = React.createClass({
     // IOS only allows click events to be delegated to the document on elements
     // it considers 'clickable' - anchors, buttons, etc. We fake a click handler on the
     // DOM nodes themselves. Remove if handled by React: https://github.com/facebook/react/issues/1169
-    React.findDOMNode(this.refs.modal).onclick = function () {};
-    React.findDOMNode(this.refs.backdrop).onclick = function () {};
+    React.findDOMNode(this.refs.modal).onclick = function() {};
+    React.findDOMNode(this.refs.backdrop).onclick = function() {};
   },
 
   _getStyles() {
diff --git a/src/Panel.js b/src/Panel.js
@@ -103,19 +103,19 @@ const Panel = React.createClass({
       return {key: bodyElements.length};
     }
 
-    function addPanelChild (child) {
+    function addPanelChild(child) {
       bodyElements.push(cloneElement(child, getProps()));
     }
 
-    function addPanelBody (children) {
+    function addPanelBody(children) {
       bodyElements.push(
         <div className={bodyClass} {...getProps()}>
           {children}
         </div>
       );
     }
 
-    function maybeRenderPanelBody () {
+    function maybeRenderPanelBody() {
       if (panelBodyChildren.length === 0) {
         return;
       }
diff --git a/src/SubNav.js b/src/SubNav.js
@@ -62,7 +62,7 @@ const SubNav = React.createClass({
 
       ValidComponentChildren.forEach(
         child.props.children,
-        function (grandchild) {
+        function(grandchild) {
           if (this.isChildActive(grandchild)) {
             isActive = true;
           }
diff --git a/src/TabbedArea.js b/src/TabbedArea.js
@@ -15,7 +15,7 @@ const TabbedArea = React.createClass({
   render() {
     const {children, ...props} = this.props;
 
-    const tabs = ValidComponentChildren.map(children, function (child) {
+    const tabs = ValidComponentChildren.map(children, function(child) {
       const {tab: title, ...others} = child.props;
       return <TabPane title={title} {...others} />;
     });
diff --git a/src/Tabs.js b/src/Tabs.js
@@ -250,7 +250,7 @@ const Tabs = React.createClass({
     let panesColProps;
     if (paneWidth == null) {
       panesColProps = {};
-      Object.keys(tabsColProps).forEach(function (size) {
+      Object.keys(tabsColProps).forEach(function(size) {
         panesColProps[size] = styleMaps.GRID_COLUMNS - tabsColProps[size];
       });
     } else if (paneWidth instanceof Object) {
diff --git a/src/utils/ValidComponentChildren.js b/src/utils/ValidComponentChildren.js
@@ -15,7 +15,7 @@ import React from 'react';
 function mapValidComponents(children, func, context) {
   let index = 0;
 
-  return React.Children.map(children, function (child) {
+  return React.Children.map(children, function(child) {
     if (React.isValidElement(child)) {
       let lastIndex = index;
       index++;
@@ -40,7 +40,7 @@ function mapValidComponents(children, func, context) {
 function forEachValidComponents(children, func, context) {
   let index = 0;
 
-  return React.Children.forEach(children, function (child) {
+  return React.Children.forEach(children, function(child) {
     if (React.isValidElement(child)) {
       func.call(context, child, index);
       index++;
@@ -57,7 +57,7 @@ function forEachValidComponents(children, func, context) {
 function numberOfValidComponents(children) {
   let count = 0;
 
-  React.Children.forEach(children, function (child) {
+  React.Children.forEach(children, function(child) {
     if (React.isValidElement(child)) { count++; }
   });
 
@@ -73,7 +73,7 @@ function numberOfValidComponents(children) {
 function hasValidComponent(children) {
   let hasValid = false;
 
-  React.Children.forEach(children, function (child) {
+  React.Children.forEach(children, function(child) {
     if (!hasValid && React.isValidElement(child)) {
       hasValid = true;
     }
diff --git a/src/utils/createContextWrapper.js b/src/utils/createContextWrapper.js
@@ -4,7 +4,7 @@ import React from 'react';
  * Creates new trigger class that injects context into overlay.
  */
 export default function createContextWrapper(Trigger, propName) {
-  return function (contextTypes) {
+  return function(contextTypes) {
     class ContextWrapper extends React.Component {
       getChildContext() {
         return this.props.context;
diff --git a/test/.eslintrc b/test/.eslintrc
@@ -19,6 +19,7 @@
     "react/jsx-quotes": 0,
     "react/no-multi-comp": 0,
     "react/prop-types": 0,
+    "space-before-function-paren": 0,
     "mocha/no-exclusive-tests": 2
   }
 }
diff --git a/test/AlertSpec.js b/test/AlertSpec.js
@@ -2,8 +2,8 @@ import React from 'react';
 import ReactTestUtils from 'react/lib/ReactTestUtils';
 import Alert from '../src/Alert';
 
-describe('Alert', function () {
-  it('Should output a alert with message', function () {
+describe('Alert', function() {
+  it('Should output a alert with message', function() {
     let instance = ReactTestUtils.renderIntoDocument(
       <Alert>
         <strong>Message</strong>
@@ -12,7 +12,7 @@ describe('Alert', function () {
     assert.ok(ReactTestUtils.findRenderedDOMComponentWithTag(instance, 'strong'));
   });
 
-  it('Should have bsType by default', function () {
+  it('Should have bsType by default', function() {
     let instance = ReactTestUtils.renderIntoDocument(
       <Alert>
         Message
@@ -21,8 +21,8 @@ describe('Alert', function () {
     assert.ok(React.findDOMNode(instance).className.match(/\balert\b/));
   });
 
-  it('Should have dismissable style with onDismiss', function () {
-    let noOp = function () {};
+  it('Should have dismissable style with onDismiss', function() {
+    let noOp = function() {};
     let instance = ReactTestUtils.renderIntoDocument(
       <Alert onDismiss={noOp}>
         Message
@@ -31,8 +31,8 @@ describe('Alert', function () {
     assert.ok(React.findDOMNode(instance).className.match(/\balert-dismissable\b/));
   });
 
-  it('Should call onDismiss callback on dismiss click', function (done) {
-    let doneOp = function () {
+  it('Should call onDismiss callback on dismiss click', function(done) {
+    let doneOp = function() {
       done();
     };
     let instance = ReactTestUtils.renderIntoDocument(
@@ -43,8 +43,8 @@ describe('Alert', function () {
     ReactTestUtils.Simulate.click(React.findDOMNode(instance).children[0]);
   });
 
-  it('Should call onDismiss callback on dismissAfter time', function (done) {
-    let doneOp = function () {
+  it('Should call onDismiss callback on dismissAfter time', function(done) {
+    let doneOp = function() {
       done();
     };
     ReactTestUtils.renderIntoDocument(
@@ -54,7 +54,7 @@ describe('Alert', function () {
     );
   });
 
-  it('Should have a default bsStyle class', function () {
+  it('Should have a default bsStyle class', function() {
     let instance = ReactTestUtils.renderIntoDocument(
       <Alert>
         Message
@@ -63,7 +63,7 @@ describe('Alert', function () {
     assert.ok(React.findDOMNode(instance).className.match(/\balert-\w+\b/));
   });
 
-  it('Should have use bsStyle class', function () {
+  it('Should have use bsStyle class', function() {
     let instance = ReactTestUtils.renderIntoDocument(
       <Alert bsStyle='danger'>
         Message
@@ -73,7 +73,7 @@ describe('Alert', function () {
   });
 
   describe('Web Accessibility', function() {
-    it('Should have alert role', function () {
+    it('Should have alert role', function() {
       let instance = ReactTestUtils.renderIntoDocument(
         <Alert>Message</Alert>
       );
@@ -82,7 +82,7 @@ describe('Alert', function () {
     });
 
     it('Should call onDismiss callback when the sr-only dismiss link is activated', function(done) {
-      let doneOp = function () {
+      let doneOp = function() {
         done();
       };
       let instance = ReactTestUtils.renderIntoDocument(
diff --git a/tools/promisify.js b/tools/promisify.js
@@ -1,5 +1,5 @@
 export default function promisify(fn) {
-  return function (...args) {
+  return function(...args) {
     return new Promise(function(resolve, reject) {
       function finish(err, result) {
         if (err) {
diff --git a/tools/public-components.js b/tools/public-components.js
@@ -2,7 +2,7 @@ import React from 'react';
 import * as index from '../src/index';
 
 let components = [];
-Object.keys(index).forEach(function (item) {
+Object.keys(index).forEach(function(item) {
   if (index[item] instanceof React.Component.constructor) {
     components.push(item);
   }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@`
`30`	`30`	`"react/jsx-no-duplicate-props": 2,`
`31`	`31`	`"react/prop-types": [2, { "ignore": [ "children", "className", "style" ] }],`
`32`	`32`	`"react/sort-comp": 0,`
`33`		`- "space-before-function-paren": 0,`
`34`	`33`	`"spaced-comment": 0,`
`35`	`34`	`"vars-on-top": 0`
`36`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-function alertClicked () {`
	`1`	`+function alertClicked() {`
`2`	`2`	`alert('You clicked the third ListGroupItem');`
`3`	`3`	`}`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-function handleSelect (selectedKey) {`
	`1`	`+function handleSelect(selectedKey) {`
`2`	`2`	`alert('selected ' + selectedKey);`
`3`	`3`	`}`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ if (runCoverage) {`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`
`21`		`-module.exports = function (config) {`
	`21`	`+module.exports = function(config) {`
`22`	`22`	`config.set({`
`23`	`23`
`24`	`24`	`basePath: '',`