Default value for second arg of Buffer#slice

ry · ry · commit 77fc61d5395a · 2010-09-14T15:39:27.000-07:00
diff --git a/doc/api.markdown b/doc/api.markdown
@@ -175,7 +175,7 @@ into `buf2`, starting at the 8th byte in `buf2`.
     // !!!!!!!!qrst!!!!!!!!!!!!!
     
 
-### buffer.slice(start, end)
+### buffer.slice(start, end=buffer.length)
 
 Returns a new buffer which references the
 same memory as the old, but offset and cropped by the `start` and `end`
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -322,12 +322,9 @@ Buffer.prototype.copy = function copy (target, target_start, start, end) {
 
 // slice(start, end)
 Buffer.prototype.slice = function (start, end) {
-  if (end > this.length) {
-    throw new Error("oob");
-  }
-  if (start > end) {
-    throw new Error("oob");
-  }
+  if (!end) end = this.length;
+  if (end > this.length) throw new Error("oob");
+  if (start > end) throw new Error("oob");
 
   return new Buffer(this.parent, end - start, +start + this.offset);
 };
diff --git a/test/simple/test-buffer.js b/test/simple/test-buffer.js
@@ -312,3 +312,9 @@ for (i = 0; i < l; i++) {
 sb = b.toString();
 assert.equal(sb.length, s.length);
 assert.equal(sb, s);
+
+
+// Single argument slice
+b = new Buffer("abcde");
+assert.equal("bcde", b.slice(1).toString());
+
