fixed minor code issues (jooby-project#1154)

feffi · jknack · commit dfe17e33605d · 2018-06-25T10:01:15.000-03:00
diff --git a/modules/jooby-ehcache/src/main/java/org/jooby/ehcache/EhSessionStore.java b/modules/jooby-ehcache/src/main/java/org/jooby/ehcache/EhSessionStore.java
@@ -235,7 +235,7 @@
  */
 public class EhSessionStore implements Session.Store {
 
-  private Ehcache cache;
+  private final Ehcache cache;
 
   @Inject
   public EhSessionStore(@Named("session") final Ehcache cache) {
diff --git a/modules/jooby-ehcache/src/main/java/org/jooby/internal/ehcache/CacheConfigurationBuilder.java b/modules/jooby-ehcache/src/main/java/org/jooby/internal/ehcache/CacheConfigurationBuilder.java
@@ -222,7 +222,7 @@
 
 public class CacheConfigurationBuilder extends EhCacheBuilder {
 
-  private String path;
+  private final String path;
 
   private CacheConfiguration cache;
 
@@ -320,12 +320,10 @@ private void cacheLoaderFactory(final Config conf) {
       cache.addCacheLoaderFactory(newFactory(path + ".cacheLoaderFactory", conf,
           CacheLoaderFactoryConfiguration::new));
     } else {
-      each(conf, (name, c) -> {
-        cache.addCacheLoaderFactory(
-            newFactory(path + ".cacheLoaderFactory." + name, c,
-                CacheLoaderFactoryConfiguration::new)
-            );
-      });
+      each(conf, (name, c) -> cache.addCacheLoaderFactory(
+          newFactory(path + ".cacheLoaderFactory." + name, c,
+              CacheLoaderFactoryConfiguration::new)
+          ));
     }
   }
 
@@ -352,12 +350,10 @@ private void cacheDecoratorFactory(final Config conf) {
               CacheDecoratorFactoryConfiguration::new)
           );
     } else {
-      each(conf, (name, decoconf) -> {
-        cache.addCacheDecoratorFactory(
-            newFactory(path + ".cacheDecoratorFactory." + name, decoconf,
-                CacheDecoratorFactoryConfiguration::new)
-            );
-      });
+      each(conf, (name, decoconf) -> cache.addCacheDecoratorFactory(
+          newFactory(path + ".cacheDecoratorFactory." + name, decoconf,
+              CacheDecoratorFactoryConfiguration::new)
+          ));
     }
   }
 
@@ -370,12 +366,10 @@ private void cacheExtensionFactory(final Config conf) {
       cache.addCacheExtensionFactory(newFactory(path + ".cacheExtensionFactory", conf,
           CacheExtensionFactoryConfiguration::new));
     } else {
-      each(conf, (name, decoconf) -> {
-        cache.addCacheExtensionFactory(
-            newFactory(path + ".cacheExtensionFactory." + name, decoconf,
-                CacheExtensionFactoryConfiguration::new)
-            );
-      });
+      each(conf, (name, decoconf) -> cache.addCacheExtensionFactory(
+          newFactory(path + ".cacheExtensionFactory." + name, decoconf,
+              CacheExtensionFactoryConfiguration::new)
+          ));
     }
   }
 
diff --git a/modules/jooby-ehcache/src/main/java/org/jooby/internal/ehcache/ConfigurationBuilder.java b/modules/jooby-ehcache/src/main/java/org/jooby/internal/ehcache/ConfigurationBuilder.java
@@ -213,7 +213,7 @@
 
 public class ConfigurationBuilder extends EhCacheBuilder {
 
-  private Configuration eh;
+  private final Configuration eh;
 
   public ConfigurationBuilder() {
     this.eh = new Configuration();
@@ -288,12 +288,10 @@ private void cacheManagerPeerProviderFactory(final Config conf) {
           newFactory("ehcache.cacheManagerPeerProviderFactory", conf, FactoryConfiguration::new)
           );
     } else {
-      each(conf, (name, c) -> {
-        eh.addCacheManagerPeerProviderFactory(
-            newFactory("ehcache.cacheManagerPeerProviderFactory." + name, c,
-                FactoryConfiguration::new)
-            );
-      });
+      each(conf, (name, c) -> eh.addCacheManagerPeerProviderFactory(
+          newFactory("ehcache.cacheManagerPeerProviderFactory." + name, c,
+              FactoryConfiguration::new)
+          ));
     }
   }
 
