remove unused header method from upload

jknack · jknack · commit b5917cef2376 · 2015-04-14T20:25:55.000-03:00
diff --git a/jooby-netty/src/main/java/org/jooby/internal/netty/NettyUpload.java b/jooby-netty/src/main/java/org/jooby/internal/netty/NettyUpload.java
@@ -55,8 +55,7 @@ public String name() {
     return data.getFilename();
   }
 
-  @Override
-  public Optional<String> header(final String name) {
+  private Optional<String> header(final String name) {
     switch (name.toLowerCase()) {
       case "content-transfer-encoding":
         return Optional.of(data.getContentTransferEncoding());
diff --git a/jooby-servlet/src/main/java/org/jooby/servlet/ServletUpload.java b/jooby-servlet/src/main/java/org/jooby/servlet/ServletUpload.java
@@ -25,7 +25,6 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
-import java.util.Optional;
 
 import javax.servlet.http.Part;
 
@@ -59,11 +58,6 @@ public String name() {
     return upload.getSubmittedFileName();
   }
 
-  @Override
-  public Optional<String> header(final String name) {
-    return Optional.ofNullable(upload.getHeader(name));
-  }
-
   @Override
   public List<String> headers(final String name) {
     Collection<String> headers = upload.getHeaders(name.toLowerCase());
diff --git a/jooby-undertow/src/main/java/org/jooby/internal/undertow/UndertowUpload.java b/jooby-undertow/src/main/java/org/jooby/internal/undertow/UndertowUpload.java
@@ -25,7 +25,6 @@
 import java.io.IOException;
 import java.util.Collections;
 import java.util.List;
-import java.util.Optional;
 
 import org.jooby.spi.NativeUpload;
 
@@ -48,11 +47,6 @@ public String name() {
     return value.getFileName();
   }
 
-  @Override
-  public Optional<String> header(final String name) {
-    return Optional.ofNullable(value.getHeaders().getFirst(name));
-  }
-
   @Override
   public List<String> headers(final String name) {
     HeaderValues values = value.getHeaders().get(name);
diff --git a/jooby/src/main/java/org/jooby/spi/NativeUpload.java b/jooby/src/main/java/org/jooby/spi/NativeUpload.java
@@ -22,7 +22,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.util.List;
-import java.util.Optional;
 
 /**
  * File upload from multipart/form-data post.
@@ -37,14 +36,6 @@ public interface NativeUpload extends Closeable {
    */
   String name();
 
-  /**
-   * File header, like <code>Content-Type</code>, <code>Content-Transfer-Encoding</code>, etc.
-   *
-   * @param name Header's name.
-   * @return A header value or empty optional.
-   */
-  Optional<String> header(String name);
-
   /**
    * Get all the file headers for the given name.
    *

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,7 @@ public String name() {`
`55`	`55`	`return data.getFilename();`
`56`	`56`	`}`
`57`	`57`
`58`		`- @Override`
`59`		`- public Optional<String> header(final String name) {`
	`58`	`+ private Optional<String> header(final String name) {`
`60`	`59`	`switch (name.toLowerCase()) {`
`61`	`60`	`case "content-transfer-encoding":`
`62`	`61`	`return Optional.of(data.getContentTransferEncoding());`