Bad media type: *; q=.2 fix jooby-project#197

jknack · jknack · commit ad5b8e7032eb · 2015-09-30T21:19:44.000-03:00
diff --git a/jooby/src/main/java/org/jooby/MediaType.java b/jooby/src/main/java/org/jooby/MediaType.java
@@ -499,6 +499,10 @@ public static MediaType valueOf(final String type) {
       return aliastype;
     }
     String[] parts = type.trim().split(";");
+    if (parts[0].equals("*")) {
+      // odd and ugly media type
+      return MediaType.all;
+    }
     String[] typeAndSubtype = parts[0].split("/");
     checkArgument(typeAndSubtype.length == 2, "Bad media type: %s", type);
     String stype = typeAndSubtype[0].trim();
@@ -616,4 +620,4 @@ public static Optional<MediaType> byExtension(final String ext) {
     return Optional.empty();
   }
 
-}
+}
diff --git a/jooby/src/test/java/org/jooby/issues/Issue197.java b/jooby/src/test/java/org/jooby/issues/Issue197.java
@@ -0,0 +1,15 @@
+package org.jooby.issues;
+
+import static org.junit.Assert.assertEquals;
+
+import org.jooby.MediaType;
+import org.junit.Test;
+
+public class Issue197 {
+
+  @Test
+  public void shouldParseOddMediaType() {
+    MediaType type = MediaType.parse("*; q=.2").iterator().next();
+    assertEquals("*/*", type.name());
+  }
+}
