Skip to content

[BUG] feature_user_total_purchase_in_90days in get started notebook uses incorrect agg_func #647

Closed

Description

@blrchen

Willingness to contribute

No. I cannot contribute a bug fix at this time.

Feathr version

v0.7.2

System information

N/A

Describe the problem

In getting start notebook, the agg_func used for feature_user_total_purchase_in_90days is AVG, it should be corrected to SUM

Feature(name="feature_user_total_purchase_in_90days",
                        key=user_id,
                        feature_type=FLOAT,
                        transform=WindowAggTransformation(agg_expr="cast_float(purchase_amount)",
                                                          agg_func="AVG",
                                                          window="90d"))

Tracking information

No response

Code to reproduce bug

No response

What component(s) does this bug affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React

Activity

  1. assigned and unassigned on Sep 13, 2022
  2. loomlike commented on Jan 5, 2023

    @loomlike
    Collaborator

    Thanks for the finding. It will be fixed (to use AVG) along with a fix for the typo in the feature name from the notebook update PR #921

    agg_features = [
        Feature(
            name="feature_user_avg_purchase_for_90days",
            key=user_id,
            feature_type=FLOAT,
            transform=WindowAggTransformation(
                agg_expr="cast_float(purchase_amount)", agg_func="AVG", window="90d"
            ),
        )
    ]
    
  3. assigned and unassigned on Jan 5, 2023
  4. blrchen commented on Jan 11, 2023

    @blrchen
    CollaboratorAuthor

    Closing as this resolved in PR #921.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions