NumberFormatter: fix for HashLink

joshtynjala · joshtynjala · commit 1e2554b1f853 · 2022-08-18T15:51:30.000-07:00
diff --git a/src/feathers/formatters/NumberFormatter.hx b/src/feathers/formatters/NumberFormatter.hx
@@ -354,7 +354,8 @@ class NumberFormatter extends Formatter {
 			return "";
 		}
 
-		if (decimalSeparatorTo == "" || !Math.isNaN(Std.parseFloat(decimalSeparatorTo))) {
+		// some versions of HL incorrectly parse "." as 0
+		if (#if hl decimalSeparatorTo != "." && #end (decimalSeparatorTo == "" || !Math.isNaN(Std.parseFloat(decimalSeparatorTo)))) {
 			error = Formatter.defaultInvalidFormatError;
 			return "";
 		}

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,8 @@ class NumberFormatter extends Formatter {`
`354`	`354`	`return "";`
`355`	`355`	`}`
`356`	`356`
`357`		`- if (decimalSeparatorTo == "" \|\| !Math.isNaN(Std.parseFloat(decimalSeparatorTo))) {`
	`357`	`+ // some versions of HL incorrectly parse "." as 0`
	`358`	`+ if (#if hl decimalSeparatorTo != "." && #end (decimalSeparatorTo == "" \|\| !Math.isNaN(Std.parseFloat(decimalSeparatorTo)))) {`
`358`	`359`	`error = Formatter.defaultInvalidFormatError;`
`359`	`360`	`return "";`
`360`	`361`	`}`