Repository navigation
Fix count query when using params.knex - #145
Merged
Merged
Conversation
Member
|
Great, thank you! Released as v3.0.3 |
Contributor
Author
|
Should note that until knex/knex#51 is addressed, this will break when using with |
Contributor
Author
|
A workaround is to use a sub-query when doing distinct, so |
|
I don't mean to revive an old PR, but I was hoping @omeid could give a little more details on your workaround? If the table's Here is a snippet from my hook: const value = params.query['$distinct'];
delete params.query['$distinct'];
context.params.knex =context.service.createQuery(params).clearSelect().distinct(value); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121