Repository navigation
add transaction support to nested service calls - #130
Merged
Merged
Conversation
Member
|
Sorry, I almost missed this! This looks great, thank you for doing this. Is there a way we can test this? I just added the transaction hooks to the normal tests to make sure they at least don't break but it doesn't cover the case of nested service calls. |
Contributor
Author
|
We could create two other services with one service's hook calling the other one inside a transaction. I think this should fail before and pass now. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
Using the proposed solution in the issue. If any extra tests are necessary please let me know.