Subscribe to Redis messages after Redis client connects. Subscribing before connection causes _RedisCommandsQueue_pubSubState in node-redis 4.x to get set resulting in 'AuthError: Cannot send commands in PubSub mode' error. (#180)

babysealclubber · Chang Lee · web-flow · commit 5b9754402bc8 · 2022-03-15T14:38:34.000-07:00
Co-authored-by: Chang Lee &lt;c.lee@servicepower.com&gt;
diff --git a/lib/adapters/redis.js b/lib/adapters/redis.js
@@ -17,6 +17,11 @@ module.exports = config => {
     const pub = redisClient || redis.createClient(options);
     const sub = pub.duplicate();
 
+    const msgFromRedisHandler = data => {
+      debug(`Got ${key} message from Redis`);
+      app.emit('sync-in', data);
+    };
+
     app.configure(core);
     app.sync = {
       deserialize,
@@ -29,17 +34,12 @@ module.exports = config => {
         sub.connect();
         sub.once('ready', resolve);
         sub.once('error', reject);
-      })
+      }).then(() => sub.subscribe(key, msgFromRedisHandler, true))
     };
 
     app.on('sync-out', data => {
       debug(`Publishing key ${key} to Redis`);
       pub.publish(key, data);
     });
-
-    sub.subscribe(key, data => {
-      debug(`Got ${key} message from Redis`);
-      app.emit('sync-in', data);
-    }, true);
   };
 };
