Skip to content

Why is there an init method in this service? #183

Closed

Description

@bertho-zero

Why is there an init method in this service? this method is not documented and uses knex before the application setup.

Activity

  1. daffl commented on Jan 7, 2019

    @daffl
    Member

    Dang, I should've removed that in the latest release. I don't think it is being used anywhere anymore (except for maybe the tests which can be easily changed).

  2. bertho-zero commented on Jan 8, 2019

    @bertho-zero
    ContributorAuthor

    Ok, init is also used in feathers-rethinkdb.

  3. bertho-zero commented on Aug 27, 2019

    @bertho-zero
    ContributorAuthor

    @daffl Should not this be removed with v4.3.0 ?

  4. daffl commented on Aug 27, 2019

    @daffl
    Member

    Oh, I forgot about this. Would you mind submitting a PR? It'll be a breaking change but it should be fine since the database adapters are versioned independently anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions