feat(core): add app.addSetup for asynchronous configuration steps#2510
Closed
vonagam wants to merge 2 commits intofeathersjs:dovefrom
Closed
feat(core): add app.addSetup for asynchronous configuration steps#2510vonagam wants to merge 2 commits intofeathersjs:dovefrom
app.addSetup for asynchronous configuration steps#2510vonagam wants to merge 2 commits intofeathersjs:dovefrom
Conversation
Member
|
I like this idea. It nicely solves the concerns you had in #2500 (comment). Looks good to me. |
Member
Author
|
I will close this one since recent hooks for But will note that setting |
Member
|
Ah yes, I meant to get back to ask if that new one may not cover everything but I'm hoping it will suffice. Ugh, I thought I kept your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to #2500 and contains small fixes from #1611.
Adds
app.addSetup()which allows adding asynchronous configuration/initialization steps.Those will run with services setups during
app.setup()call.Services use this method to add their own setup calls to queue,
so one can add a step that runs before or after a specific service setup.
This is for cases when you don't have an appropriate service to implement
setupmethod in.Will add tests if that sounds as a reasonable addition.