fix: ESLint errors - remove this aliasing and unused import

marshallswain · marshallswain · commit da29174ed7cb · 2026-01-10T01:02:53.000-07:00
diff --git a/packages/feathers/src/hooks.ts b/packages/feathers/src/hooks.ts
@@ -192,10 +192,9 @@ export function hookMixin<A>(this: A, service: FeathersService<A>, path: string,
     return service
   }
 
-  const app = this
   const hookMethods = getHookMethods(service, options)
 
-  const createMethodHookManager = (method: string) => {
+  const createMethodHookManager = (app: A, method: string) => {
     const params = (defaultServiceArguments as any)[method] || ['data', 'params']
 
     return new FeathersHookManager<A>(app, method).params(...params).props({
@@ -216,7 +215,7 @@ export function hookMixin<A>(this: A, service: FeathersService<A>, path: string,
   }
 
   const serviceMethodHooks = hookMethods.reduce((res, method) => {
-    res[method] = createMethodHookManager(method)
+    res[method] = createMethodHookManager(this, method)
     return res
   }, {} as BaseHookMap)
 
@@ -227,7 +226,18 @@ export function hookMixin<A>(this: A, service: FeathersService<A>, path: string,
 
   hooks(service, serviceMethodHooks)
 
-  service.hooks = function (this: any, hookOptions: any) {
+  service.hooks = createServiceHooksMethod(this, service, registerHooks, createMethodHookManager)
+
+  return service
+}
+
+function createServiceHooksMethod<A>(
+  app: A,
+  service: FeathersService<A>,
+  registerHooks: ReturnType<typeof enableHooks>,
+  createMethodHookManager: (app: A, method: string) => FeathersHookManager<A>
+) {
+  return function (this: any, hookOptions: any) {
     if (hookOptions.before || hookOptions.after || hookOptions.error || hookOptions.around) {
       return registerHooks.call(this, hookOptions)
     }
@@ -250,7 +260,7 @@ export function hookMixin<A>(this: A, service: FeathersService<A>, path: string,
           throw new Error(`Method ${method} does not exist on this service`)
         }
 
-        const methodManager = createMethodHookManager(method)
+        const methodManager = createMethodHookManager(app, method)
         hooks(this, { [method]: methodManager })
         manager = methodManager
       }
@@ -260,6 +270,4 @@ export function hookMixin<A>(this: A, service: FeathersService<A>, path: string,
 
     return this
   }
-
-  return service
 }
diff --git a/packages/feathers/src/http/index.test.ts b/packages/feathers/src/http/index.test.ts
@@ -3,7 +3,7 @@ import { createServer } from 'node:http'
 import { restTests, verify, getApp, createTestServer } from '../../fixtures/index.js'
 import { CORS_HEADERS, createHandler } from './index.js'
 import { toNodeHandler } from './node.js'
-import { feathers, Params } from '../index.js'
+import { feathers } from '../index.js'
 
 const TEST_PORT = 4444
 const EXTERNAL_METHODS_PORT = 4445
