fix: @feathersjs/memory update with query (#3617)

fratzinger · web-flow · commit 4c6caa27e9af · 2025-09-30T12:43:36.000-07:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/adapter-tests/src/methods.ts b/packages/adapter-tests/src/methods.ts
@@ -292,6 +292,9 @@ export default (test: AdapterMethodsTest, app: any, _errors: any, serviceName: s
         } catch (error: any) {
           assert.strictEqual(error.name, 'NotFound', 'Got a NotFound Feathers error')
         }
+
+        const updatedDoug = await service.get(doug[idProp])
+        assert.strictEqual(updatedDoug.name, 'Doug', 'Doug was not updated')
       })
 
       test('.update + NotFound', async () => {
diff --git a/packages/memory/package.json b/packages/memory/package.json
@@ -50,7 +50,6 @@
   },
   "dependencies": {
     "@feathersjs/adapter-commons": "^5.0.35",
-    "@feathersjs/commons": "^5.0.35",
     "@feathersjs/errors": "^5.0.35",
     "sift": "^17.1.3"
   },
diff --git a/packages/memory/src/index.ts b/packages/memory/src/index.ts
@@ -1,5 +1,4 @@
 import { BadRequest, MethodNotAllowed, NotFound } from '@feathersjs/errors'
-import { _ } from '@feathersjs/commons'
 import {
   sorter,
   select,
@@ -75,11 +74,11 @@ export class MemoryAdapter<
     const { paginate } = this.getOptions(params)
     const { query, filters } = this.getQuery(params)
 
-    let values = _.values(this.store)
+    let values = Object.values(this.store)
     const hasSkip = filters.$skip !== undefined
     const hasSort = filters.$sort !== undefined
     const hasLimit = filters.$limit !== undefined
-    const hasQuery = _.keys(query).length > 0
+    const hasQuery = Object.keys(query).length > 0
 
     if (hasSort) {
       values.sort(this.options.sorter(filters.$sort))
@@ -171,8 +170,8 @@ export class MemoryAdapter<
     }
 
     const id = (data as any)[this.id] || this._uId++
-    const current = _.extend({}, data, { [this.id]: id })
-    const result = (this.store[id] = current)
+    const current = { ...data, [this.id]: id }
+    const result = (this.store[id] = current as any)
 
     return _select(result, params, this.id) as Result
   }
@@ -182,14 +181,9 @@ export class MemoryAdapter<
       throw new BadRequest("You can not replace multiple instances. Did you mean 'patch'?")
     }
 
-    const oldEntry = await this._get(id)
-    // We don't want our id to change type if it can be coerced
-    const oldId = (oldEntry as any)[this.id]
+    const oldEntry = await this._get(id, params)
 
-    // eslint-disable-next-line eqeqeq
-    id = oldId == id ? oldId : id
-
-    this.store[id] = _.extend({}, data, { [this.id]: id })
+    this.store[id] = { ...data, [this.id]: (oldEntry as any)[this.id] } as Result
 
     return this._get(id, params)
   }
@@ -214,7 +208,11 @@ export class MemoryAdapter<
     const patchEntry = (entry: Result) => {
       const currentId = (entry as any)[this.id]
 
-      this.store[currentId] = _.extend(this.store[currentId], _.omit(data, this.id))
+      this.store[currentId] = {
+        ...this.store[currentId],
+        ...data,
+        [this.id]: (entry as any)[this.id]
+      }
 
       return _select(this.store[currentId], params, this.id)
     }

Original file line number	Diff line number	Diff line change
`@@ -292,6 +292,9 @@ export default (test: AdapterMethodsTest, app: any, _errors: any, serviceName: s`
`292`	`292`	`} catch (error: any) {`
`293`	`293`	`assert.strictEqual(error.name, 'NotFound', 'Got a NotFound Feathers error')`
`294`	`294`	`}`
	`295`	`+`
	`296`	`+ const updatedDoug = await service.get(doug[idProp])`
	`297`	`+ assert.strictEqual(updatedDoug.name, 'Doug', 'Doug was not updated')`
`295`	`298`	`})`
`296`	`299`
`297`	`300`	`test('.update + NotFound', async () => {`