Skip to content

Commit 12ed64e

Browse files
daffldaffl
committed
chore: Get crow build passing again
1 parent 325e633 commit 12ed64e

File tree

26 files changed

+147
-122
lines changed

26 files changed

+147
-122
lines changed

‎.github/workflows/nodejs.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
node-version: [10.x, 12.x, 13.x]
12+
node-version: [12.x, 14.x]
1313

1414
steps:
1515
- uses: actions/checkout@v2

‎package-lock.json‎

Lines changed: 54 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"lint": "tslint 'packages/**/*.js' 'packages/**/*.ts' -c tslint.json --fix",
2929
"update-dependencies": "ncu -u && lerna exec -- ncu -u",
3030
"clean": "find . -name node_modules -exec rm -rf '{}' + && find . -name package-lock.json -exec rm -rf '{}' +",
31-
"test": "npm run lint && nyc lerna run test"
31+
"test": "nyc lerna run test"
3232
},
3333
"devDependencies": {
3434
"lerna": "^3.22.1",

‎packages/adapter-commons/test/filter-query.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ describe('@feathersjs/adapter-commons/filterQuery', () => {
4242
const query = { $foo: 1 };
4343
filterQuery(query);
4444
assert.ok(false, 'Should never get here');
45-
} catch (error) {
45+
} catch (error: any) {
4646
assert.strictEqual(error.name, 'BadRequest');
4747
assert.strictEqual(error.message, 'Invalid query parameter $foo');
4848
}
@@ -218,7 +218,7 @@ describe('@feathersjs/adapter-commons/filterQuery', () => {
218218
try {
219219
filterQuery({ $select: 1, $known: 1 });
220220
assert.ok(false, 'Should never get here');
221-
} catch (error) {
221+
} catch (error: any) {
222222
assert.strictEqual(error.message, 'Invalid query parameter $known');
223223
}
224224
});

‎packages/adapter-tests/src/methods.ts‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
1616
afterEach(async () => {
1717
try {
1818
await app.service(serviceName).remove(doug[idProp]);
19-
} catch (error) {}
19+
} catch (error: any) {}
2020
});
2121

2222
describe('get', () => {
@@ -48,7 +48,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
4848
query: { name: 'Tester' }
4949
});
5050
throw new Error('Should never get here');
51-
} catch (error) {
51+
} catch (error: any) {
5252
assert.strictEqual(error.name, 'NotFound',
5353
'Got a NotFound Feathers error'
5454
);
@@ -59,7 +59,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
5959
try {
6060
await service.get('568225fbfe21222432e836ff');
6161
throw new Error('Should never get here');
62-
} catch (error) {
62+
} catch (error: any) {
6363
assert.strictEqual(error.name, 'NotFound',
6464
'Error is a NotFound Feathers error'
6565
);
@@ -77,7 +77,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
7777
query: { [idProp]: alice[idProp] }
7878
});
7979
throw new Error('Should never get here');
80-
} catch (error) {
80+
} catch (error: any) {
8181
assert.strictEqual(error.name, 'NotFound',
8282
'Got a NotFound Feathers error'
8383
);
@@ -118,7 +118,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
118118
query: { name: 'Tester' }
119119
});
120120
throw new Error('Should never get here');
121-
} catch (error) {
121+
} catch (error: any) {
122122
assert.strictEqual(error.name, 'NotFound',
123123
'Got a NotFound Feathers error'
124124
);
@@ -129,7 +129,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
129129
try {
130130
await service.remove(null);
131131
throw new Error('Should never get here');
132-
} catch (error) {
132+
} catch (error: any) {
133133
assert.strictEqual(error.name, 'MethodNotAllowed',
134134
'Removing multiple without option set throws MethodNotAllowed'
135135
);
@@ -167,7 +167,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
167167
query: { [idProp]: alice[idProp] }
168168
});
169169
throw new Error('Should never get here');
170-
} catch (error) {
170+
} catch (error: any) {
171171
assert.strictEqual(error.name, 'NotFound',
172172
'Got a NotFound Feathers error'
173173
);
@@ -217,7 +217,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
217217
query: { name: 'Tester' }
218218
});
219219
throw new Error('Should never get here');
220-
} catch (error) {
220+
} catch (error: any) {
221221
assert.strictEqual(error.name, 'NotFound',
222222
'Got a NotFound Feathers error'
223223
);
@@ -228,7 +228,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
228228
try {
229229
await service.update('568225fbfe21222432e836ff', { name: 'NotFound' });
230230
throw new Error('Should never get here');
231-
} catch (error) {
231+
} catch (error: any) {
232232
assert.strictEqual(error.name, 'NotFound',
233233
'Error is a NotFound Feathers error'
234234
);
@@ -244,7 +244,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
244244
{ query: { name: 'NotDave' } }
245245
);
246246
throw new Error('Should never get here');
247-
} catch (error) {
247+
} catch (error: any) {
248248
assert.strictEqual(error.name, 'NotFound',
249249
'Error is a NotFound Feathers error'
250250
);
@@ -266,7 +266,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
266266
query: { [idProp]: alice[idProp] }
267267
});
268268
throw new Error('Should never get here');
269-
} catch (error) {
269+
} catch (error: any) {
270270
assert.strictEqual(error.name, 'NotFound',
271271
'Got a NotFound Feathers error'
272272
);
@@ -312,7 +312,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
312312
query: { name: 'Tester' }
313313
});
314314
throw new Error('Should never get here');
315-
} catch (error) {
315+
} catch (error: any) {
316316
assert.strictEqual(error.name, 'NotFound',
317317
'Got a NotFound Feathers error'
318318
);
@@ -323,7 +323,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
323323
try {
324324
await service.patch(null, {});
325325
throw new Error('Should never get here');
326-
} catch (error) {
326+
} catch (error: any) {
327327
assert.strictEqual(error.name, 'MethodNotAllowed',
328328
'Removing multiple without option set throws MethodNotAllowed'
329329
);
@@ -417,7 +417,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
417417
try {
418418
await service.patch('568225fbfe21222432e836ff', { name: 'PatchDoug' });
419419
throw new Error('Should never get here');
420-
} catch (error) {
420+
} catch (error: any) {
421421
assert.strictEqual(error.name, 'NotFound',
422422
'Error is a NotFound Feathers error'
423423
);
@@ -433,7 +433,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
433433
{ query: { name: 'NotDave' } }
434434
);
435435
throw new Error('Should never get here');
436-
} catch (error) {
436+
} catch (error: any) {
437437
assert.strictEqual(error.name, 'NotFound',
438438
'Error is a NotFound Feathers error'
439439
);
@@ -454,7 +454,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
454454
query: { [idProp]: alice[idProp] }
455455
});
456456
throw new Error('Should never get here');
457-
} catch (error) {
457+
} catch (error: any) {
458458
assert.strictEqual(error.name, 'NotFound',
459459
'Got a NotFound Feathers error'
460460
);
@@ -503,7 +503,7 @@ export default (test: any, app: any, _errors: any, serviceName: string, idProp:
503503
try {
504504
await service.create([], {});
505505
throw new Error('Should never get here');
506-
} catch (error) {
506+
} catch (error: any) {
507507
assert.strictEqual(error.name, 'MethodNotAllowed',
508508
'Removing multiple without option set throws MethodNotAllowed'
509509
);

‎packages/authentication-client/src/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ declare module '@feathersjs/feathers' {
1818
export const getDefaultStorage = () => {
1919
try {
2020
return new StorageWrapper(window.localStorage);
21-
} catch (error) {}
21+
} catch (error: any) {}
2222

2323
return new MemoryStorage();
2424
};

‎packages/authentication-client/test/index.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ describe('@feathersjs/authentication-client', () => {
9090
hash: 'error=Error Happened&x=y'
9191
} as Location);
9292
assert.fail('Should never get here');
93-
} catch (error) {
93+
} catch (error: any) {
9494
assert.strictEqual(error.name, 'NotAuthenticated');
9595
assert.strictEqual(error.message, 'Error Happened');
9696
}

‎packages/authentication-local/test/hooks/hash-password.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('@feathersjs/authentication-local/hooks/hash-password', () => {
1919
// @ts-ignore
2020
hashPassword();
2121
assert.fail('Should never get here');
22-
} catch (error) {
22+
} catch (error: any) {
2323
assert.strictEqual(error.message, 'The hashPassword hook requires a field name option');
2424
}
2525
});
@@ -33,7 +33,7 @@ describe('@feathersjs/authentication-local/hooks/hash-password', () => {
3333
password: 'supersecret'
3434
});
3535
assert.fail('Should never get here');
36-
} catch (error) {
36+
} catch (error: any) {
3737
assert.strictEqual(error.message,
3838
'Could not find an authentication service to hash password'
3939
);
@@ -49,7 +49,7 @@ describe('@feathersjs/authentication-local/hooks/hash-password', () => {
4949
password: 'supersecret'
5050
});
5151
assert.fail('Should never get here');
52-
} catch (error) {
52+
} catch (error: any) {
5353
assert.strictEqual(error.message,
5454
`Could not find 'local' strategy to hash password`
5555
);
@@ -71,7 +71,7 @@ describe('@feathersjs/authentication-local/hooks/hash-password', () => {
7171
password: 'supersecret'
7272
});
7373
assert.fail('Should never get here');
74-
} catch (error) {
74+
} catch (error: any) {
7575
assert.strictEqual(error.message,
7676
`The 'hashPassword' hook should only be used as a 'before' hook`
7777
);

0 commit comments

Comments
 (0)