From 535af9972e0ffc9f0172aac38122992ab81248b1 Mon Sep 17 00:00:00 2001
From: Brad Bohen <bbohen@gmail.com>
Date: Wed, 4 Oct 2017 22:37:30 -0400
Subject: [PATCH 1/3] feat: Updated replace() to pass id from placeholder
 element

---
 README.md      | 6 +++---
 src/replace.js | 3 ++-
 src/to-svg.js  | 4 +++-
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index a4a99186..602563d7 100644
--- a/README.md
+++ b/README.md
@@ -228,13 +228,13 @@ You can pass `feather.replace()` an `options` object:
 </script>
 ```
 
-All classes on a placeholder element (i.e. `<i>`) will be copied to the `<svg>` tag:
+The id and classes on a placeholder element (i.e. `<i>`) will be copied to the `<svg>` tag:
 
 ```html
-<i class="foo bar" data-feather="circle"></i>
+<i id="my-circle-icon" class="foo bar" data-feather="circle"></i>
 <!--
 <i> will be replaced with:
-<svg class="feather feather-circle foo bar" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><circle cx="12" cy="12" r="10"></circle></svg>
+<svg id="my-circle-icon" class="feather feather-circle foo bar" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><circle cx="12" cy="12" r="10"></circle></svg>
 -->
 
 <script>
diff --git a/src/replace.js b/src/replace.js
index 7c551885..5ebe3b4b 100644
--- a/src/replace.js
+++ b/src/replace.js
@@ -42,11 +42,12 @@ function replaceElement(element, options) {
   }
 
   const elementClassAttr = element.getAttribute('class') || '';
+  const elementId = element.getAttribute('id');
   const classNames = (
     options.class ? `${options.class} ${elementClassAttr}` : elementClassAttr
   );
 
-  const svgString = toSvg(key, Object.assign({}, options, { class: classNames }));
+  const svgString = toSvg(key, Object.assign({}, options, { class: classNames, id: elementId }));
   const svgDocument = new DOMParser().parseFromString(svgString, 'image/svg+xml');
   const svgElement = svgDocument.querySelector('svg');
 
diff --git a/src/to-svg.js b/src/to-svg.js
index 253cc51a..4634d6e0 100644
--- a/src/to-svg.js
+++ b/src/to-svg.js
@@ -68,7 +68,9 @@ function optionsToAtrributes(options) {
   const attributes = [];
 
   Object.keys(options).forEach(key => {
-    attributes.push(`${key}="${options[key]}"`);
+    if (options[key]) {
+      attributes.push(`${key}="${options[key]}"`);
+    }
   });
 
   return attributes.join(' ');

From 5b81d0848cbc98c449347559c84ae37829c0030f Mon Sep 17 00:00:00 2001
From: Brad Bohen <bbohen@gmail.com>
Date: Wed, 4 Oct 2017 22:52:17 -0400
Subject: [PATCH 2/3] refactor: Fixes minor typo

---
 src/to-svg.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/to-svg.js b/src/to-svg.js
index 4634d6e0..c00a19ef 100644
--- a/src/to-svg.js
+++ b/src/to-svg.js
@@ -35,7 +35,7 @@ export default function toSvg(key, options = {}) {
 
   combinedOptions.class = addDefaultClassNames(combinedOptions.class, key);
 
-  const attributes = optionsToAtrributes(combinedOptions);
+  const attributes = optionsToAttributes(combinedOptions);
 
   return `<svg ${attributes}>${icons[key]}</svg>`;
 }
@@ -64,7 +64,7 @@ function addDefaultClassNames(classNames, key) {
  * @param {Object} options
  * @returns {string}
  */
-function optionsToAtrributes(options) {
+function optionsToAttributes(options) {
   const attributes = [];
 
   Object.keys(options).forEach(key => {

From e6996bfe15e5b7d610c0e76ee83892fbcc084bff Mon Sep 17 00:00:00 2001
From: Brad Bohen <bbohen@gmail.com>
Date: Thu, 5 Oct 2017 08:08:59 -0400
Subject: [PATCH 3/3] refactor: Updated name of constant for consistency

---
 src/replace.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/replace.js b/src/replace.js
index 5ebe3b4b..e322b10c 100644
--- a/src/replace.js
+++ b/src/replace.js
@@ -42,12 +42,13 @@ function replaceElement(element, options) {
   }
 
   const elementClassAttr = element.getAttribute('class') || '';
-  const elementId = element.getAttribute('id');
+  const elementIdAttr = element.getAttribute('id');
   const classNames = (
     options.class ? `${options.class} ${elementClassAttr}` : elementClassAttr
   );
 
-  const svgString = toSvg(key, Object.assign({}, options, { class: classNames, id: elementId }));
+  const svgOptions = Object.assign({}, options, { class: classNames, id: elementIdAttr });
+  const svgString = toSvg(key, svgOptions);
   const svgDocument = new DOMParser().parseFromString(svgString, 'image/svg+xml');
   const svgElement = svgDocument.querySelector('svg');