Skip to content

Commit b09413d

Browse files
jasonlewisjasonlewis
committed
Refactoring config tests.
Signed-off-by: Jason Lewis <jason.lewis1991@gmail.com>
1 parent 973b6bc commit b09413d

1 file changed

Lines changed: 37 additions & 51 deletions

File tree

‎tests/config.test.php‎

Lines changed: 37 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -2,93 +2,79 @@
22

33
class ConfigTest extends PHPUnit_Framework_TestCase {
44

5-
public function testItemsCanBeSet()
5+
public $feather;
6+
7+
public function setUp()
68
{
7-
$config = $this->getRepository();
9+
$this->feather = Feather\Components\Support\Facade::application();
810

9-
$config->set('name', 'jason');
10-
$this->assertEquals('jason', $config->get('name'));
11+
$this->feather['config']->set('test', $this->items());
12+
}
1113

12-
$config->set('person.name', 'jason');
13-
$this->assertEquals('jason', $config->get('person.name'));
14+
public function testItemsCanBeSet()
15+
{
16+
$this->feather['config']->set('name', 'jason');
17+
$this->assertEquals('jason', $this->feather['config']->get('name'));
1418

15-
$config->set('namespace::person.name', 'jason');
16-
$this->assertEquals('jason', $config->get('namespace::person.name'));
19+
$this->feather['config']->set('person.name', 'jason');
20+
$this->assertEquals('jason', $this->feather['config']->get('person.name'));
1721

18-
$config->set('gear: mock person.name', 'jason');
19-
$this->assertEquals('jason', $config->get('gear: mock person.name'));
22+
$this->feather['config']->set('namespace::person.name', 'jason');
23+
$this->assertEquals('jason', $this->feather['config']->get('namespace::person.name'));
2024

21-
$config->set('theme: mock person.name', 'jason');
22-
$this->assertEquals('jason', $config->get('theme: mock person.name'));
25+
$this->feather['config']->set('gear: mock person.name', 'jason');
26+
$this->assertEquals('jason', $this->feather['config']->get('gear: mock person.name'));
27+
28+
$this->feather['config']->set('theme: mock person.name', 'jason');
29+
$this->assertEquals('jason', $this->feather['config']->get('theme: mock person.name'));
2330
}
2431

2532
public function testGetBasicItems()
2633
{
27-
$config = $this->getRepository();
28-
29-
$this->assertEquals('bar', $config->get('test.foo'));
30-
$this->assertEquals('orange', $config->get('test.apple'));
34+
$this->assertEquals('bar', $this->feather['config']->get('test.foo'));
35+
$this->assertEquals('orange', $this->feather['config']->get('test.apple'));
3136
}
3237

3338
public function testEntireArrayCanBeReturned()
3439
{
35-
$config = $this->getRepository();
36-
37-
$this->assertEquals($this->getItems(), $config->get('test'));
40+
$this->assertEquals($this->items(), $this->feather['config']->get('test'));
3841
}
3942

4043
public function testCheckItemExistance()
4144
{
42-
$config = $this->getRepository();
43-
44-
$config->set('foo', 'bar');
45-
$this->assertTrue($config->has('foo'));
45+
$this->feather['config']->set('foo', 'bar');
4646

47-
$this->assertTrue(!$config->has('apple'));
47+
$this->assertTrue($this->feather['config']->has('foo'));
48+
$this->assertTrue(!$this->feather['config']->has('apple'));
4849
}
4950

5051
public function testItemsCanBeSaved()
5152
{
52-
$config = $this->getRepository();
53+
$this->feather['config']->set('feather: db.test', 'foobar');
54+
$this->feather['config']->save('feather: db.test');
5355

54-
$config->set('feather: db.test', 'foobar');
55-
$config->save('feather: db.test');
56+
$this->feather['config']->reload();
5657

57-
$config->reload();
58+
$this->assertEquals('foobar', $this->feather['config']->get('feather: db.test'));
5859

59-
$this->assertEquals('foobar', $config->get('feather: db.test'));
60-
61-
$config->delete('feather: db.test');
60+
$this->feather['config']->delete('feather: db.test');
6261
}
6362

6463
public function testItemsCanBeDeleted()
6564
{
66-
$config = $this->getRepository();
67-
68-
$config->set('feather: db.test', 'foobar');
69-
$config->save('feather: db.test');
70-
71-
$config->reload();
72-
73-
$config->delete('feather: db.test');
65+
$this->feather['config']->set('feather: db.test', 'foobar');
66+
$this->feather['config']->save('feather: db.test');
7467

75-
$config->reload();
76-
77-
$this->assertEquals(null, $config->get('feather: db.test'));
78-
}
79-
80-
private function getRepository()
81-
{
82-
$feather = Feather\Components\Support\Facade::application();
68+
$this->feather['config']->reload();
8369

84-
$config = $feather['config'];
70+
$this->feather['config']->delete('feather: db.test');
8571

86-
$config->set('test', $this->getItems());
72+
$this->feather['config']->reload();
8773

88-
return $config;
74+
$this->assertEquals(null, $this->feather['config']->get('feather: db.test'));
8975
}
9076

91-
private function getItems()
77+
public function items()
9278
{
9379
return array('foo' => 'bar', 'apple' => 'orange');
9480
}

0 commit comments

Comments
 (0)