docs: clarify FeatureView ttl behavior#6481
Open
adrynalean wants to merge 1 commit into
Open
Conversation
Signed-off-by: adrynalean <87601800+adrynalean@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Clarifies the
FeatureView.ttldocs so the Python API docstring describes TTL as the historical feature lookup window instead of saying the feature group "lives" for that amount of time.It also adds a short note to the feature view concept docs that
FeatureView.ttldoes not by itself configure database-level expiration for feature values in online stores.Which issue(s) this PR fixes:
Refs #4133
Checks
git commit -s)Testing Strategy
Manual check:
python -m py_compile sdk/python/feast/feature_view.pygit diff --checkMisc
This is intended as a docs-only clarification of current behavior, not a runtime change or a resolution of the broader online-store TTL design discussion in #4133.