From 8354dcf78020d15da6c9ee392a45f9985232b9a6 Mon Sep 17 00:00:00 2001 From: antznette1 Date: Thu, 9 Apr 2026 12:05:09 +0100 Subject: [PATCH 1/2] Fix helm podAnnotations metrics context Signed-off-by: antznette1 --- infra/charts/feast-feature-server/templates/deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/infra/charts/feast-feature-server/templates/deployment.yaml b/infra/charts/feast-feature-server/templates/deployment.yaml index 6cd17d4a4d1..902473d92a7 100644 --- a/infra/charts/feast-feature-server/templates/deployment.yaml +++ b/infra/charts/feast-feature-server/templates/deployment.yaml @@ -14,7 +14,7 @@ spec: {{- with .Values.podAnnotations }} annotations: {{- toYaml . | nindent 8 }} - {{- if .Values.metrics.enabled }} + {{- if $.Values.metrics.enabled }} instrumentation.opentelemetry.io/inject-python: "true" {{- end }} {{- end }} From 9cfde89e7648bb07ac12d5f14202dfa0a765d3cd Mon Sep 17 00:00:00 2001 From: antznette1 Date: Thu, 9 Apr 2026 12:33:41 +0100 Subject: [PATCH 2/2] Fix helm metrics annotation with empty podAnnotations Signed-off-by: antznette1 --- infra/charts/feast-feature-server/templates/deployment.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/infra/charts/feast-feature-server/templates/deployment.yaml b/infra/charts/feast-feature-server/templates/deployment.yaml index 902473d92a7..ef0cc9671de 100644 --- a/infra/charts/feast-feature-server/templates/deployment.yaml +++ b/infra/charts/feast-feature-server/templates/deployment.yaml @@ -11,9 +11,11 @@ spec: {{- include "feast-feature-server.selectorLabels" . | nindent 6 }} template: metadata: - {{- with .Values.podAnnotations }} + {{- if or .Values.podAnnotations .Values.metrics.enabled }} annotations: + {{- with .Values.podAnnotations }} {{- toYaml . | nindent 8 }} + {{- end }} {{- if $.Values.metrics.enabled }} instrumentation.opentelemetry.io/inject-python: "true" {{- end }}