From 74de8edf913d91c81d9c7a2fcfa42a19d8ac022c Mon Sep 17 00:00:00 2001 From: Francisco Javier Arceo Date: Tue, 15 Apr 2025 20:51:13 -0400 Subject: [PATCH] fix: Update actions to remove check skip tests Signed-off-by: Francisco Javier Arceo --- .github/workflows/java_pr.yml | 12 +++--------- .../workflows/operator-e2e-integration-tests.yml | 8 +------- .github/workflows/operator_pr.yml | 7 ------- .github/workflows/pr_integration_tests.yml | 8 +------- .github/workflows/pr_local_integration_tests.yml | 8 +------- .../workflows/pr_remote_rbac_integration_tests.yml | 8 +------- .github/workflows/smoke_tests.yml | 9 +-------- .github/workflows/unit_tests.yml | 14 -------------- 8 files changed, 8 insertions(+), 66 deletions(-) diff --git a/.github/workflows/java_pr.yml b/.github/workflows/java_pr.yml index 4562c5df73e..3ccb7f34b62 100644 --- a/.github/workflows/java_pr.yml +++ b/.github/workflows/java_pr.yml @@ -11,18 +11,12 @@ permissions: pull-requests: read jobs: - check_skip_tests: - uses: ./.github/workflows/check_skip_tests.yml - with: - head-sha: ${{ github.event.pull_request.head.sha }} - excluded-dirs: 'docs/**,tests/**,examples/**' - lint-java: # when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes. if: ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && - github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false' + github.repository == 'feast-dev/feast' runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -41,7 +35,7 @@ jobs: if: ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && - github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false' + github.repository == 'feast-dev/feast' runs-on: ubuntu-latest needs: lint-java steps: @@ -119,7 +113,7 @@ jobs: if: ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && - github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false' + github.repository == 'feast-dev/feast' runs-on: ubuntu-latest needs: unit-test-java env: diff --git a/.github/workflows/operator-e2e-integration-tests.yml b/.github/workflows/operator-e2e-integration-tests.yml index d69b4d202c8..41954daff68 100644 --- a/.github/workflows/operator-e2e-integration-tests.yml +++ b/.github/workflows/operator-e2e-integration-tests.yml @@ -14,18 +14,12 @@ on: - 'infra/**' jobs: - check_skip_tests: - uses: ./.github/workflows/check_skip_tests.yml - with: - head-sha: ${{ github.event.pull_request.head.sha }} - excluded-dirs: 'docs/**,tests/**,examples/**' - operator-e2e-tests: timeout-minutes: 40 if: ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && - github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false' + github.repository == 'feast-dev/feast' runs-on: ubuntu-latest services: diff --git a/.github/workflows/operator_pr.yml b/.github/workflows/operator_pr.yml index 3d0fc81a4bf..aefdcbdcbb4 100644 --- a/.github/workflows/operator_pr.yml +++ b/.github/workflows/operator_pr.yml @@ -2,14 +2,7 @@ name: operator-pr on: [pull_request] jobs: - check_skip_tests: - uses: ./.github/workflows/check_skip_tests.yml - with: - head-sha: ${{ github.event.pull_request.head.sha }} - excluded-dirs: 'docs/**,tests/**,examples/**' - operator-test: - if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml index 8ccda80eac7..b8fe5747d66 100644 --- a/.github/workflows/pr_integration_tests.yml +++ b/.github/workflows/pr_integration_tests.yml @@ -16,18 +16,12 @@ permissions: pull-requests: read jobs: - check_skip_tests: - uses: ./.github/workflows/check_skip_tests.yml - with: - head-sha: ${{ github.event.pull_request.head.sha }} - excluded-dirs: 'docs/**,tests/**,examples/**' - integration-test-python: # when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes. if: ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && - github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false' + github.repository == 'feast-dev/feast' runs-on: ${{ matrix.os }} strategy: fail-fast: false diff --git a/.github/workflows/pr_local_integration_tests.yml b/.github/workflows/pr_local_integration_tests.yml index 73512c1b2d3..0787b8a3f2c 100644 --- a/.github/workflows/pr_local_integration_tests.yml +++ b/.github/workflows/pr_local_integration_tests.yml @@ -9,17 +9,11 @@ on: - labeled jobs: - check_skip_tests: - uses: ./.github/workflows/check_skip_tests.yml - with: - head-sha: ${{ github.event.pull_request.head.sha }} - excluded-dirs: 'docs/**,tests/**,examples/**' - integration-test-python-local: if: ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && - github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false' + github.event.pull_request.base.repo.full_name == 'feast-dev/feast' runs-on: ${{ matrix.os }} strategy: fail-fast: false diff --git a/.github/workflows/pr_remote_rbac_integration_tests.yml b/.github/workflows/pr_remote_rbac_integration_tests.yml index 315ac6c224f..56c59a544c9 100644 --- a/.github/workflows/pr_remote_rbac_integration_tests.yml +++ b/.github/workflows/pr_remote_rbac_integration_tests.yml @@ -9,17 +9,11 @@ on: - labeled jobs: - check_skip_tests: - uses: ./.github/workflows/check_skip_tests.yml - with: - head-sha: ${{ github.event.pull_request.head.sha }} - excluded-dirs: 'docs/**,tests/**,examples/**' - remote-rbac-integration-tests-python: if: ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && - github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false' + github.event.pull_request.base.repo.full_name == 'feast-dev/feast' runs-on: ${{ matrix.os }} strategy: fail-fast: false diff --git a/.github/workflows/smoke_tests.yml b/.github/workflows/smoke_tests.yml index 5149c9ad8bc..6f469866136 100644 --- a/.github/workflows/smoke_tests.yml +++ b/.github/workflows/smoke_tests.yml @@ -4,14 +4,7 @@ on: pull_request: jobs: - check_skip_tests: - uses: ./.github/workflows/check_skip_tests.yml - with: - head-sha: ${{ github.event.pull_request.head.sha }} - excluded-dirs: 'docs/**,tests/**,examples/**' - - unit-test-python: - if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }} + smoke-test-python: runs-on: ${{ matrix.os }} strategy: fail-fast: false diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 198a725e8b0..b909d591369 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -4,20 +4,7 @@ on: pull_request: jobs: - check_skip_tests: - runs-on: ubuntu-latest - outputs: - skip_tests: ${{ steps.check.outputs.skip_tests }} - steps: - - uses: actions/checkout@v4 - - id: check - uses: ./.github/actions/check-skip-tests - with: - head-sha: ${{ github.event.pull_request.head.sha || github.sha }} - unit-test-python: - needs: [check_skip_tests] - if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }} runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -55,7 +42,6 @@ jobs: run: uv cache prune --ci unit-test-ui: - if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }} runs-on: ubuntu-latest env: NPM_TOKEN: ${{ secrets.NPM_TOKEN }}