From 67a63cbb136a95efe93a784d4c19e392b86f3515 Mon Sep 17 00:00:00 2001 From: Tommy Hughes Date: Tue, 11 Mar 2025 10:00:43 -0500 Subject: [PATCH] chore: Decommision the feast-helm-operator Signed-off-by: Tommy Hughes --- .github/workflows/publish_images.yml | 2 +- .releaserc.js | 1 - Makefile | 12 - .../running-feast-in-production.md | 2 - infra/feast-helm-operator/.gitignore | 14 -- infra/feast-helm-operator/Dockerfile | 7 - infra/feast-helm-operator/Makefile | 231 ------------------ infra/feast-helm-operator/PROJECT | 20 -- infra/feast-helm-operator/README.md | 39 --- .../charts.feast.dev_feastfeatureservers.yaml | 44 ---- .../config/crd/kustomization.yaml | 6 - .../config/default/kustomization.yaml | 20 -- .../config/manager/kustomization.yaml | 8 - .../config/manager/manager.yaml | 101 -------- .../config/manifests/kustomization.yaml | 7 - .../rbac/feastfeatureserver_editor_role.yaml | 39 --- ...feastfeatureserver_editor_rolebinding.yaml | 19 -- .../config/rbac/kustomization.yaml | 13 - .../config/rbac/leader_election_role.yaml | 44 ---- .../rbac/leader_election_role_binding.yaml | 19 -- .../feast-helm-operator/config/rbac/role.yaml | 30 --- .../config/rbac/role_binding.yaml | 19 -- .../config/rbac/service_account.yaml | 12 - .../charts_v1alpha1_feastfeatureserver.yaml | 29 --- .../config/samples/kustomization.yaml | 4 - .../config/scorecard/bases/config.yaml | 7 - .../config/scorecard/kustomization.yaml | 16 -- .../scorecard/patches/basic.config.yaml | 10 - .../config/scorecard/patches/olm.config.yaml | 50 ---- .../helm-charts/feast-feature-server | 1 - infra/feast-helm-operator/watches.yaml | 6 - infra/scripts/release/files_to_bump.txt | 2 - 32 files changed, 1 insertion(+), 833 deletions(-) delete mode 100644 infra/feast-helm-operator/.gitignore delete mode 100644 infra/feast-helm-operator/Dockerfile delete mode 100644 infra/feast-helm-operator/Makefile delete mode 100644 infra/feast-helm-operator/PROJECT delete mode 100644 infra/feast-helm-operator/README.md delete mode 100644 infra/feast-helm-operator/config/crd/bases/charts.feast.dev_feastfeatureservers.yaml delete mode 100644 infra/feast-helm-operator/config/crd/kustomization.yaml delete mode 100644 infra/feast-helm-operator/config/default/kustomization.yaml delete mode 100644 infra/feast-helm-operator/config/manager/kustomization.yaml delete mode 100644 infra/feast-helm-operator/config/manager/manager.yaml delete mode 100644 infra/feast-helm-operator/config/manifests/kustomization.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_role.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_rolebinding.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/kustomization.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/leader_election_role.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/leader_election_role_binding.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/role.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/role_binding.yaml delete mode 100644 infra/feast-helm-operator/config/rbac/service_account.yaml delete mode 100644 infra/feast-helm-operator/config/samples/charts_v1alpha1_feastfeatureserver.yaml delete mode 100644 infra/feast-helm-operator/config/samples/kustomization.yaml delete mode 100644 infra/feast-helm-operator/config/scorecard/bases/config.yaml delete mode 100644 infra/feast-helm-operator/config/scorecard/kustomization.yaml delete mode 100644 infra/feast-helm-operator/config/scorecard/patches/basic.config.yaml delete mode 100644 infra/feast-helm-operator/config/scorecard/patches/olm.config.yaml delete mode 120000 infra/feast-helm-operator/helm-charts/feast-feature-server delete mode 100644 infra/feast-helm-operator/watches.yaml diff --git a/.github/workflows/publish_images.yml b/.github/workflows/publish_images.yml index 120634c5c91..0919454c841 100644 --- a/.github/workflows/publish_images.yml +++ b/.github/workflows/publish_images.yml @@ -29,7 +29,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - component: [ feature-server, feature-server-java, feature-transformation-server, feast-helm-operator, feast-operator ] + component: [ feature-server, feature-server-java, feature-transformation-server, feast-operator ] env: MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar REGISTRY: quay.io/feastdev diff --git a/.releaserc.js b/.releaserc.js index 249005262d3..f609bcefa21 100644 --- a/.releaserc.js +++ b/.releaserc.js @@ -66,7 +66,6 @@ module.exports = { "CHANGELOG.md", "java/pom.xml", "infra/charts/**/*.*", - "infra/feast-helm-operator/**/*", "infra/feast-operator/**/*", "ui/package.json", "sdk/python/feast/infra/feature_servers/multicloud/requirements.txt", diff --git a/Makefile b/Makefile index c33685ef2cb..4259d7b7c19 100644 --- a/Makefile +++ b/Makefile @@ -528,18 +528,6 @@ build-feature-server-java-docker: -t $(REGISTRY)/feature-server-java:$(VERSION) \ -f java/infra/docker/feature-server/Dockerfile --load . -push-feast-helm-operator-docker: - cd infra/feast-helm-operator && \ - IMAGE_TAG_BASE=$(REGISTRY)/feast-helm-operator \ - VERSION=$(VERSION) \ - $(MAKE) docker-push - -build-feast-helm-operator-docker: - cd infra/feast-helm-operator && \ - IMAGE_TAG_BASE=$(REGISTRY)/feast-helm-operator \ - VERSION=$(VERSION) \ - $(MAKE) docker-build - push-feast-operator-docker: cd infra/feast-operator && \ IMAGE_TAG_BASE=$(REGISTRY)/feast-operator \ diff --git a/docs/how-to-guides/running-feast-in-production.md b/docs/how-to-guides/running-feast-in-production.md index aa277c2540a..1e4998ce23a 100644 --- a/docs/how-to-guides/running-feast-in-production.md +++ b/docs/how-to-guides/running-feast-in-production.md @@ -225,8 +225,6 @@ helm install feast-release feast-charts/feast-feature-server \ This will deploy a single service. The service must have read access to the registry file on cloud storage and to the online store (e.g. via [podAnnotations](https://kubernetes-on-aws.readthedocs.io/en/latest/user-guide/iam-roles.html)). It will keep a copy of the registry in their memory and periodically refresh it, so expect some delays in update propagation in exchange for better performance. -> Alternatively, deploy the same helm chart with a [Kubernetes Operator](/infra/feast-helm-operator). - ## 5. Using environment variables in your yaml configuration You might want to dynamically set parts of your configuration from your environment. For instance to deploy Feast to production and development with the same configuration, but a different server. Or to inject secrets without exposing them in your git repo. To do this, it is possible to use the `${ENV_VAR}` syntax in your `feature_store.yaml` file. For instance: diff --git a/infra/feast-helm-operator/.gitignore b/infra/feast-helm-operator/.gitignore deleted file mode 100644 index 62fd3e3995f..00000000000 --- a/infra/feast-helm-operator/.gitignore +++ /dev/null @@ -1,14 +0,0 @@ - -# Binaries for programs and plugins -*.exe -*.exe~ -*.dll -*.so -*.dylib -bin - -# editor and IDE paraphernalia -.idea -*.swp -*.swo -*~ diff --git a/infra/feast-helm-operator/Dockerfile b/infra/feast-helm-operator/Dockerfile deleted file mode 100644 index 0aad602c2d2..00000000000 --- a/infra/feast-helm-operator/Dockerfile +++ /dev/null @@ -1,7 +0,0 @@ -# Build the manager binary -FROM quay.io/operator-framework/helm-operator:v1.34.1 - -ENV HOME=/opt/helm -COPY watches.yaml ${HOME}/watches.yaml -COPY --from=helmcharts feast-feature-server ${HOME}/helm-charts/feast-feature-server -WORKDIR ${HOME} diff --git a/infra/feast-helm-operator/Makefile b/infra/feast-helm-operator/Makefile deleted file mode 100644 index dafe368f844..00000000000 --- a/infra/feast-helm-operator/Makefile +++ /dev/null @@ -1,231 +0,0 @@ -# VERSION defines the project version for the bundle. -# Update this value when you upgrade the version of your project. -# To re-generate a bundle for another specific version without changing the standard setup, you can: -# - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2) -# - use environment variables to overwrite this value (e.g export VERSION=0.0.2) -VERSION ?= 0.47.0 - -# CHANNELS define the bundle channels used in the bundle. -# Add a new line here if you would like to change its default config. (E.g CHANNELS = "candidate,fast,stable") -# To re-generate a bundle for other specific channels without changing the standard setup, you can: -# - use the CHANNELS as arg of the bundle target (e.g make bundle CHANNELS=candidate,fast,stable) -# - use environment variables to overwrite this value (e.g export CHANNELS="candidate,fast,stable") -ifneq ($(origin CHANNELS), undefined) -BUNDLE_CHANNELS := --channels=$(CHANNELS) -endif - -# DEFAULT_CHANNEL defines the default channel used in the bundle. -# Add a new line here if you would like to change its default config. (E.g DEFAULT_CHANNEL = "stable") -# To re-generate a bundle for any other default channel without changing the default setup, you can: -# - use the DEFAULT_CHANNEL as arg of the bundle target (e.g make bundle DEFAULT_CHANNEL=stable) -# - use environment variables to overwrite this value (e.g export DEFAULT_CHANNEL="stable") -ifneq ($(origin DEFAULT_CHANNEL), undefined) -BUNDLE_DEFAULT_CHANNEL := --default-channel=$(DEFAULT_CHANNEL) -endif -BUNDLE_METADATA_OPTS ?= $(BUNDLE_CHANNELS) $(BUNDLE_DEFAULT_CHANNEL) - -# IMAGE_TAG_BASE defines the quay.io namespace and part of the image name for remote images. -# This variable is used to construct full image tags for bundle and catalog images. -# -# For example, running 'make bundle-build bundle-push catalog-build catalog-push' will build and push both -# quay.io/feastdev/feast-helm-operator-bundle:$VERSION and quay.io/feastdev/feast-helm-operator-catalog:$VERSION. -IMAGE_TAG_BASE ?= quay.io/feastdev/feast-helm-operator - -# BUNDLE_IMG defines the image:tag used for the bundle. -# You can use it as an arg. (E.g make bundle-build BUNDLE_IMG=/:) -BUNDLE_IMG ?= $(IMAGE_TAG_BASE)-bundle:v$(VERSION) - -# BUNDLE_GEN_FLAGS are the flags passed to the operator-sdk generate bundle command -BUNDLE_GEN_FLAGS ?= -q --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS) - -# USE_IMAGE_DIGESTS defines if images are resolved via tags or digests -# You can enable this value if you would like to use SHA Based Digests -# To enable set flag to true -USE_IMAGE_DIGESTS ?= false -ifeq ($(USE_IMAGE_DIGESTS), true) - BUNDLE_GEN_FLAGS += --use-image-digests -endif - -# Set the Operator SDK version to use. By default, what is installed on the system is used. -# This is useful for CI or a project to utilize a specific version of the operator-sdk toolkit. -OPERATOR_SDK_VERSION ?= v1.34.1 - -KUSTOMIZE_VERSION ?= v5.2.1 -HELM_VERSION ?= v1.34.1 -OPM_VERSION ?= v1.23.0 - -# Image URL to use all building/pushing image targets -IMG ?= $(IMAGE_TAG_BASE):$(VERSION) - -.PHONY: all -all: docker-build - -##@ General - -# The help target prints out all targets with their descriptions organized -# beneath their categories. The categories are represented by '##@' and the -# target descriptions by '##'. The awk commands is responsible for reading the -# entire set of makefiles included in this invocation, looking for lines of the -# file as xyz: ## something, and then pretty-format the target and help. Then, -# if there's a line with ##@ something, that gets pretty-printed as a category. -# More info on the usage of ANSI control characters for terminal formatting: -# https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_parameters -# More info on the awk command: -# http://linuxcommand.org/lc3_adv_awk.php - -.PHONY: help -help: ## Display this help. - @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-15s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) - -##@ Build - -.PHONY: run -run: helm-operator ## Run against the configured Kubernetes cluster in ~/.kube/config - $(HELM_OPERATOR) run - -.PHONY: docker-build -docker-build: ## Build docker image with the manager. - docker build --build-context helmcharts=../charts/ -t ${IMG} --load . - -.PHONY: docker-push -docker-push: ## Push docker image with the manager. - docker push ${IMG} - -# PLATFORMS defines the target platforms for the manager image be build to provide support to multiple -# architectures. (i.e. make docker-buildx IMG=myregistry/mypoperator:0.0.1). To use this option you need to: -# - able to use docker buildx . More info: https://docs.docker.com/build/buildx/ -# - have enable BuildKit, More info: https://docs.docker.com/develop/develop-images/build_enhancements/ -# - be able to push the image for your registry (i.e. if you do not inform a valid value via IMG=> than the export will fail) -# To properly provided solutions that supports more than one platform you should use this option. -PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le -.PHONY: docker-buildx -docker-buildx: ## Build and push docker image for the manager for cross-platform support - - docker buildx create --name project-v3-builder - - docker buildx use project-v3-builder - - docker buildx build --push --platform=$(PLATFORMS) --build-context helmcharts=../charts/ --tag ${IMG} -f Dockerfile . - - docker buildx rm project-v3-builder - -##@ Deployment - -.PHONY: install -install: kustomize ## Install CRDs into the K8s cluster specified in ~/.kube/config. - $(KUSTOMIZE) build config/crd | kubectl apply -f - - -.PHONY: uninstall -uninstall: kustomize ## Uninstall CRDs from the K8s cluster specified in ~/.kube/config. - $(KUSTOMIZE) build config/crd | kubectl delete -f - - -.PHONY: deploy -deploy: kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config. - cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG} - $(KUSTOMIZE) build config/default | kubectl apply -f - - -.PHONY: undeploy -undeploy: kustomize ## Undeploy controller from the K8s cluster specified in ~/.kube/config. - $(KUSTOMIZE) build config/default | kubectl delete -f - - -OS := $(shell uname -s | tr '[:upper:]' '[:lower:]') -ARCH := $(shell uname -m | sed 's/x86_64/amd64/' | sed 's/aarch64/arm64/') - -.PHONY: kustomize -KUSTOMIZE = $(shell pwd)/bin/kustomize -kustomize: ## Download kustomize locally if necessary. -ifeq (,$(wildcard $(KUSTOMIZE))) -ifeq (,$(shell which kustomize 2>/dev/null)) - @{ \ - set -e ;\ - mkdir -p $(dir $(KUSTOMIZE)) ;\ - curl -sSLo - https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/$(KUSTOMIZE_VERSION)/kustomize_$(KUSTOMIZE_VERSION)_$(OS)_$(ARCH).tar.gz | \ - tar xzf - -C bin/ ;\ - } -else -KUSTOMIZE = $(shell which kustomize) -endif -endif - -.PHONY: helm-operator -HELM_OPERATOR = $(shell pwd)/bin/helm-operator -helm-operator: ## Download helm-operator locally if necessary, preferring the $(pwd)/bin path over global if both exist. -ifeq (,$(wildcard $(HELM_OPERATOR))) -ifeq (,$(shell which helm-operator 2>/dev/null)) - @{ \ - set -e ;\ - mkdir -p $(dir $(HELM_OPERATOR)) ;\ - curl -sSLo $(HELM_OPERATOR) https://github.com/operator-framework/operator-sdk/releases/download/$(HELM_VERSION)/helm-operator_$(OS)_$(ARCH) ;\ - chmod +x $(HELM_OPERATOR) ;\ - } -else -HELM_OPERATOR = $(shell which helm-operator) -endif -endif - -.PHONY: operator-sdk -OPERATOR_SDK ?= $(shell pwd)/bin/operator-sdk -operator-sdk: ## Download operator-sdk locally if necessary. -ifeq (,$(wildcard $(OPERATOR_SDK))) -ifeq (, $(shell which operator-sdk 2>/dev/null)) - @{ \ - set -e ;\ - mkdir -p $(dir $(OPERATOR_SDK)) ;\ - curl -sSLo $(OPERATOR_SDK) https://github.com/operator-framework/operator-sdk/releases/download/$(OPERATOR_SDK_VERSION)/operator-sdk_$(OS)_$(ARCH) ;\ - chmod +x $(OPERATOR_SDK) ;\ - } -else -OPERATOR_SDK = $(shell which operator-sdk) -endif -endif - -.PHONY: bundle -bundle: kustomize operator-sdk ## Generate bundle manifests and metadata, then validate generated files. - $(OPERATOR_SDK) generate kustomize manifests -q - cd config/manager && $(KUSTOMIZE) edit set image controller=$(IMG) - $(KUSTOMIZE) build config/manifests | $(OPERATOR_SDK) generate bundle $(BUNDLE_GEN_FLAGS) - $(OPERATOR_SDK) bundle validate ./bundle - -.PHONY: bundle-build -bundle-build: ## Build the bundle image. - docker build -f bundle.Dockerfile -t $(BUNDLE_IMG) . - -.PHONY: bundle-push -bundle-push: ## Push the bundle image. - $(MAKE) docker-push IMG=$(BUNDLE_IMG) - -.PHONY: opm -OPM = $(shell pwd)/bin/opm -opm: ## Download opm locally if necessary. -ifeq (,$(wildcard $(OPM))) -ifeq (,$(shell which opm 2>/dev/null)) - @{ \ - set -e ;\ - mkdir -p $(dir $(OPM)) ;\ - curl -sSLo $(OPM) https://github.com/operator-framework/operator-registry/releases/download/$(OPM_VERSION)/$(OS)-$(ARCH)-opm ;\ - chmod +x $(OPM) ;\ - } -else -OPM = $(shell which opm) -endif -endif - -# A comma-separated list of bundle images (e.g. make catalog-build BUNDLE_IMGS=example.com/operator-bundle:v0.1.0,example.com/operator-bundle:v0.2.0). -# These images MUST exist in a registry and be pull-able. -BUNDLE_IMGS ?= $(BUNDLE_IMG) - -# The image tag given to the resulting catalog image (e.g. make catalog-build CATALOG_IMG=example.com/operator-catalog:v0.2.0). -CATALOG_IMG ?= $(IMAGE_TAG_BASE)-catalog:v$(VERSION) - -# Set CATALOG_BASE_IMG to an existing catalog image tag to add $BUNDLE_IMGS to that image. -ifneq ($(origin CATALOG_BASE_IMG), undefined) -FROM_INDEX_OPT := --from-index $(CATALOG_BASE_IMG) -endif - -# Build a catalog image by adding bundle images to an empty catalog using the operator package manager tool, 'opm'. -# This recipe invokes 'opm' in 'semver' bundle add mode. For more information on add modes, see: -# https://github.com/operator-framework/community-operators/blob/7f1438c/docs/packaging-operator.md#updating-your-existing-operator -.PHONY: catalog-build -catalog-build: opm ## Build a catalog image. - $(OPM) index add --container-tool docker --mode semver --tag $(CATALOG_IMG) --bundles $(BUNDLE_IMGS) $(FROM_INDEX_OPT) - -# Push the catalog image. -.PHONY: catalog-push -catalog-push: ## Push a catalog image. - $(MAKE) docker-push IMG=$(CATALOG_IMG) diff --git a/infra/feast-helm-operator/PROJECT b/infra/feast-helm-operator/PROJECT deleted file mode 100644 index fefe00db1ec..00000000000 --- a/infra/feast-helm-operator/PROJECT +++ /dev/null @@ -1,20 +0,0 @@ -# Code generated by tool. DO NOT EDIT. -# This file is used to track the info used to scaffold your project -# and allow the plugins properly work. -# More info: https://book.kubebuilder.io/reference/project-config.html -domain: feast.dev -layout: -- helm.sdk.operatorframework.io/v1 -plugins: - manifests.sdk.operatorframework.io/v2: {} - scorecard.sdk.operatorframework.io/v2: {} -projectName: feast-helm-operator -resources: -- api: - crdVersion: v1 - namespaced: true - domain: feast.dev - group: charts - kind: FeastFeatureServer - version: v1alpha1 -version: "3" diff --git a/infra/feast-helm-operator/README.md b/infra/feast-helm-operator/README.md deleted file mode 100644 index e6d9caee9f5..00000000000 --- a/infra/feast-helm-operator/README.md +++ /dev/null @@ -1,39 +0,0 @@ -# Feast Feature Server Helm-based Operator (Deprecated replaced by [feast-operator](../feast-operator/README.md)) - -This Operator was built with the [operator-sdk](https://github.com/operator-framework/operator-sdk) and leverages the [feast-feature-server helm chart](/infra/charts/feast-feature-server). - -## Installation - -1. __Install [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/)__ -2. __Install the Operator on a Kubernetes cluster__ - -```bash -make deploy -``` - -3. __Install a Feast Feature Server on Kubernetes__ - -A base64 encoded version of the `feature_store.yaml` file is required. FeastFeatureServer CR install example: -```bash -cat < To install the aforementioned sample FeastFeatureServer, run this command - `kubectl create -f config/samples/charts_v1alpha1_feastfeatureserver.yaml` diff --git a/infra/feast-helm-operator/config/crd/bases/charts.feast.dev_feastfeatureservers.yaml b/infra/feast-helm-operator/config/crd/bases/charts.feast.dev_feastfeatureservers.yaml deleted file mode 100644 index 8c4c6a1eceb..00000000000 --- a/infra/feast-helm-operator/config/crd/bases/charts.feast.dev_feastfeatureservers.yaml +++ /dev/null @@ -1,44 +0,0 @@ ---- -apiVersion: apiextensions.k8s.io/v1 -kind: CustomResourceDefinition -metadata: - name: feastfeatureservers.charts.feast.dev -spec: - group: charts.feast.dev - names: - kind: FeastFeatureServer - listKind: FeastFeatureServerList - plural: feastfeatureservers - singular: feastfeatureserver - scope: Namespaced - versions: - - name: v1alpha1 - schema: - openAPIV3Schema: - description: FeastFeatureServer is the Schema for the feastfeatureservers API - properties: - apiVersion: - description: 'APIVersion defines the versioned schema of this representation - of an object. Servers should convert recognized schemas to the latest - internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources' - type: string - kind: - description: 'Kind is a string value representing the REST resource this - object represents. Servers may infer this from the endpoint the client - submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds' - type: string - metadata: - type: object - spec: - description: Spec defines the desired state of FeastFeatureServer - type: object - x-kubernetes-preserve-unknown-fields: true - status: - description: Status defines the observed state of FeastFeatureServer - type: object - x-kubernetes-preserve-unknown-fields: true - type: object - served: true - storage: true - subresources: - status: {} diff --git a/infra/feast-helm-operator/config/crd/kustomization.yaml b/infra/feast-helm-operator/config/crd/kustomization.yaml deleted file mode 100644 index bba243307b9..00000000000 --- a/infra/feast-helm-operator/config/crd/kustomization.yaml +++ /dev/null @@ -1,6 +0,0 @@ -# This kustomization.yaml is not intended to be run by itself, -# since it depends on service name and namespace that are out of this kustomize package. -# It should be run by config/default -resources: -- bases/charts.feast.dev_feastfeatureservers.yaml -#+kubebuilder:scaffold:crdkustomizeresource diff --git a/infra/feast-helm-operator/config/default/kustomization.yaml b/infra/feast-helm-operator/config/default/kustomization.yaml deleted file mode 100644 index 3252e11de8d..00000000000 --- a/infra/feast-helm-operator/config/default/kustomization.yaml +++ /dev/null @@ -1,20 +0,0 @@ -# Adds namespace to all resources. -namespace: feast-helm-operator-system - -# Value of this field is prepended to the -# names of all resources, e.g. a deployment named -# "wordpress" becomes "alices-wordpress". -# Note that it should also match with the prefix (text before '-') of the namespace -# field above. -namePrefix: feast-helm-operator- - -# Labels to add to all resources and selectors. -#labels: -#- includeSelectors: true -# pairs: -# someName: someValue - -resources: -- ../crd -- ../rbac -- ../manager diff --git a/infra/feast-helm-operator/config/manager/kustomization.yaml b/infra/feast-helm-operator/config/manager/kustomization.yaml deleted file mode 100644 index d0181a2d532..00000000000 --- a/infra/feast-helm-operator/config/manager/kustomization.yaml +++ /dev/null @@ -1,8 +0,0 @@ -resources: -- manager.yaml -apiVersion: kustomize.config.k8s.io/v1beta1 -kind: Kustomization -images: -- name: controller - newName: quay.io/feastdev/feast-helm-operator - newTag: 0.47.0 diff --git a/infra/feast-helm-operator/config/manager/manager.yaml b/infra/feast-helm-operator/config/manager/manager.yaml deleted file mode 100644 index 03f1fe173d8..00000000000 --- a/infra/feast-helm-operator/config/manager/manager.yaml +++ /dev/null @@ -1,101 +0,0 @@ -apiVersion: v1 -kind: Namespace -metadata: - labels: - control-plane: controller-manager - app.kubernetes.io/name: namespace - app.kubernetes.io/instance: system - app.kubernetes.io/component: manager - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: system ---- -apiVersion: apps/v1 -kind: Deployment -metadata: - name: controller-manager - namespace: system - labels: - control-plane: controller-manager - app.kubernetes.io/name: deployment - app.kubernetes.io/instance: controller-manager - app.kubernetes.io/component: manager - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize -spec: - selector: - matchLabels: - control-plane: controller-manager - replicas: 1 - template: - metadata: - annotations: - kubectl.kubernetes.io/default-container: manager - labels: - control-plane: controller-manager - spec: - # TODO(user): Uncomment the following code to configure the nodeAffinity expression - # according to the platforms which are supported by your solution. - # It is considered best practice to support multiple architectures. You can - # build your manager image using the makefile target docker-buildx. - # affinity: - # nodeAffinity: - # requiredDuringSchedulingIgnoredDuringExecution: - # nodeSelectorTerms: - # - matchExpressions: - # - key: kubernetes.io/arch - # operator: In - # values: - # - amd64 - # - arm64 - # - ppc64le - # - s390x - # - key: kubernetes.io/os - # operator: In - # values: - # - linux - securityContext: - runAsNonRoot: true - # TODO(user): For common cases that do not require escalating privileges - # it is recommended to ensure that all your Pods/Containers are restrictive. - # More info: https://kubernetes.io/docs/concepts/security/pod-security-standards/#restricted - # Please uncomment the following code if your project does NOT have to work on old Kubernetes - # versions < 1.19 or on vendors versions which do NOT support this field by default (i.e. Openshift < 4.11 ). - # seccompProfile: - # type: RuntimeDefault - containers: - - args: - - --leader-elect - - --leader-election-id=feast-helm-operator - image: controller:latest - name: manager - securityContext: - allowPrivilegeEscalation: false - capabilities: - drop: - - "ALL" - livenessProbe: - httpGet: - path: /healthz - port: 8081 - initialDelaySeconds: 15 - periodSeconds: 20 - readinessProbe: - httpGet: - path: /readyz - port: 8081 - initialDelaySeconds: 5 - periodSeconds: 10 - # TODO(user): Configure the resources accordingly based on the project requirements. - # More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ - resources: - limits: - cpu: 500m - memory: 128Mi - requests: - cpu: 10m - memory: 64Mi - serviceAccountName: controller-manager - terminationGracePeriodSeconds: 10 diff --git a/infra/feast-helm-operator/config/manifests/kustomization.yaml b/infra/feast-helm-operator/config/manifests/kustomization.yaml deleted file mode 100644 index 90dccb22c3b..00000000000 --- a/infra/feast-helm-operator/config/manifests/kustomization.yaml +++ /dev/null @@ -1,7 +0,0 @@ -# These resources constitute the fully configured set of manifests -# used to generate the 'manifests/' directory in a bundle. -resources: -- bases/feast-helm-operator.clusterserviceversion.yaml -- ../default -- ../samples -- ../scorecard diff --git a/infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_role.yaml b/infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_role.yaml deleted file mode 100644 index 4749204cf75..00000000000 --- a/infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_role.yaml +++ /dev/null @@ -1,39 +0,0 @@ -# permissions for end users to edit feastfeatureservers. -apiVersion: rbac.authorization.k8s.io/v1 -kind: ClusterRole -metadata: - labels: - app.kubernetes.io/name: clusterrole - app.kubernetes.io/instance: feastfeatureserver-editor-role - app.kubernetes.io/component: rbac - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: feastfeatureserver-editor-role -rules: -- apiGroups: - - charts.feast.dev - resources: - - feastfeatureservers - verbs: - - create - - delete - - get - - list - - patch - - update - - watch -- apiGroups: - - charts.feast.dev - resources: - - feastfeatureservers/finalizers - verbs: - - update -- apiGroups: - - charts.feast.dev - resources: - - feastfeatureservers/status - verbs: - - get - - patch - - update diff --git a/infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_rolebinding.yaml b/infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_rolebinding.yaml deleted file mode 100644 index 66c985fd00d..00000000000 --- a/infra/feast-helm-operator/config/rbac/feastfeatureserver_editor_rolebinding.yaml +++ /dev/null @@ -1,19 +0,0 @@ -apiVersion: rbac.authorization.k8s.io/v1 -kind: ClusterRoleBinding -metadata: - labels: - app.kubernetes.io/name: clusterrole - app.kubernetes.io/instance: feastfeatureserver-editor-role - app.kubernetes.io/component: rbac - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: feastfeatureserver-editor-rolebinding -roleRef: - apiGroup: rbac.authorization.k8s.io - kind: ClusterRole - name: feastfeatureserver-editor-role -subjects: -- kind: ServiceAccount - name: controller-manager - namespace: system diff --git a/infra/feast-helm-operator/config/rbac/kustomization.yaml b/infra/feast-helm-operator/config/rbac/kustomization.yaml deleted file mode 100644 index 05916243907..00000000000 --- a/infra/feast-helm-operator/config/rbac/kustomization.yaml +++ /dev/null @@ -1,13 +0,0 @@ -resources: -# All RBAC will be applied under this service account in -# the deployment namespace. You may comment out this resource -# if your manager will use a service account that exists at -# runtime. Be sure to update RoleBinding and ClusterRoleBinding -# subjects if changing service account names. -- service_account.yaml -- role.yaml -- role_binding.yaml -- leader_election_role.yaml -- leader_election_role_binding.yaml -- feastfeatureserver_editor_role.yaml -- feastfeatureserver_editor_rolebinding.yaml diff --git a/infra/feast-helm-operator/config/rbac/leader_election_role.yaml b/infra/feast-helm-operator/config/rbac/leader_election_role.yaml deleted file mode 100644 index f2523c129ff..00000000000 --- a/infra/feast-helm-operator/config/rbac/leader_election_role.yaml +++ /dev/null @@ -1,44 +0,0 @@ -# permissions to do leader election. -apiVersion: rbac.authorization.k8s.io/v1 -kind: Role -metadata: - labels: - app.kubernetes.io/name: role - app.kubernetes.io/instance: leader-election-role - app.kubernetes.io/component: rbac - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: leader-election-role -rules: -- apiGroups: - - "" - resources: - - configmaps - verbs: - - get - - list - - watch - - create - - update - - patch - - delete -- apiGroups: - - coordination.k8s.io - resources: - - leases - verbs: - - get - - list - - watch - - create - - update - - patch - - delete -- apiGroups: - - "" - resources: - - events - verbs: - - create - - patch diff --git a/infra/feast-helm-operator/config/rbac/leader_election_role_binding.yaml b/infra/feast-helm-operator/config/rbac/leader_election_role_binding.yaml deleted file mode 100644 index b56c4101678..00000000000 --- a/infra/feast-helm-operator/config/rbac/leader_election_role_binding.yaml +++ /dev/null @@ -1,19 +0,0 @@ -apiVersion: rbac.authorization.k8s.io/v1 -kind: RoleBinding -metadata: - labels: - app.kubernetes.io/name: rolebinding - app.kubernetes.io/instance: leader-election-rolebinding - app.kubernetes.io/component: rbac - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: leader-election-rolebinding -roleRef: - apiGroup: rbac.authorization.k8s.io - kind: Role - name: leader-election-role -subjects: -- kind: ServiceAccount - name: controller-manager - namespace: system diff --git a/infra/feast-helm-operator/config/rbac/role.yaml b/infra/feast-helm-operator/config/rbac/role.yaml deleted file mode 100644 index ffc82274830..00000000000 --- a/infra/feast-helm-operator/config/rbac/role.yaml +++ /dev/null @@ -1,30 +0,0 @@ -apiVersion: rbac.authorization.k8s.io/v1 -kind: ClusterRole -metadata: - labels: - app.kubernetes.io/name: clusterrole - app.kubernetes.io/instance: manager-role - app.kubernetes.io/component: rbac - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: manager-role -rules: -- apiGroups: [""] - resources: ["pods"] - verbs: ["get", "list", "watch"] -- apiGroups: - - "" - - apps - resources: - - deployments - - secrets - - services - verbs: - - create - - delete - - get - - list - - patch - - update - - watch diff --git a/infra/feast-helm-operator/config/rbac/role_binding.yaml b/infra/feast-helm-operator/config/rbac/role_binding.yaml deleted file mode 100644 index 9aa7f4264f3..00000000000 --- a/infra/feast-helm-operator/config/rbac/role_binding.yaml +++ /dev/null @@ -1,19 +0,0 @@ -apiVersion: rbac.authorization.k8s.io/v1 -kind: ClusterRoleBinding -metadata: - labels: - app.kubernetes.io/name: clusterrolebinding - app.kubernetes.io/instance: manager-rolebinding - app.kubernetes.io/component: rbac - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: manager-rolebinding -roleRef: - apiGroup: rbac.authorization.k8s.io - kind: ClusterRole - name: manager-role -subjects: -- kind: ServiceAccount - name: controller-manager - namespace: system diff --git a/infra/feast-helm-operator/config/rbac/service_account.yaml b/infra/feast-helm-operator/config/rbac/service_account.yaml deleted file mode 100644 index b2ab5d5e917..00000000000 --- a/infra/feast-helm-operator/config/rbac/service_account.yaml +++ /dev/null @@ -1,12 +0,0 @@ -apiVersion: v1 -kind: ServiceAccount -metadata: - labels: - app.kubernetes.io/name: serviceaccount - app.kubernetes.io/instance: controller-manager-sa - app.kubernetes.io/component: rbac - app.kubernetes.io/created-by: feast-helm-operator - app.kubernetes.io/part-of: feast-helm-operator - app.kubernetes.io/managed-by: kustomize - name: controller-manager - namespace: system diff --git a/infra/feast-helm-operator/config/samples/charts_v1alpha1_feastfeatureserver.yaml b/infra/feast-helm-operator/config/samples/charts_v1alpha1_feastfeatureserver.yaml deleted file mode 100644 index 44b8b61af56..00000000000 --- a/infra/feast-helm-operator/config/samples/charts_v1alpha1_feastfeatureserver.yaml +++ /dev/null @@ -1,29 +0,0 @@ -apiVersion: charts.feast.dev/v1alpha1 -kind: FeastFeatureServer -metadata: - name: feastfeatureserver-sample -spec: - # Default values copied from helm-charts/feast-feature-server/values.yaml - affinity: {} - # base64 encoding of `sdk/python/feast/templates/local/feature_repo/feature_store.yaml` - feature_store_yaml_base64: "cHJvamVjdDogbXlfcHJvamVjdAojIEJ5IGRlZmF1bHQsIHRoZSByZWdpc3RyeSBpcyBhIGZpbGUgKGJ1dCBjYW4gYmUgdHVybmVkIGludG8gYSBtb3JlIHNjYWxhYmxlIFNRTC1iYWNrZWQgcmVnaXN0cnkpCnJlZ2lzdHJ5OiBkYXRhL3JlZ2lzdHJ5LmRiCiMgVGhlIHByb3ZpZGVyIHByaW1hcmlseSBzcGVjaWZpZXMgZGVmYXVsdCBvZmZsaW5lIC8gb25saW5lIHN0b3JlcyAmIHN0b3JpbmcgdGhlIHJlZ2lzdHJ5IGluIGEgZ2l2ZW4gY2xvdWQKcHJvdmlkZXI6IGxvY2FsCm9ubGluZV9zdG9yZToKICAgIHR5cGU6IHNxbGl0ZQogICAgcGF0aDogZGF0YS9vbmxpbmVfc3RvcmUuZGIKZW50aXR5X2tleV9zZXJpYWxpemF0aW9uX3ZlcnNpb246IDIK" - fullnameOverride: "" - image: {} - imagePullSecrets: [] - livenessProbe: - initialDelaySeconds: 30 - periodSeconds: 30 - nameOverride: "" - nodeSelector: {} - podAnnotations: {} - podSecurityContext: {} - readinessProbe: - initialDelaySeconds: 20 - periodSeconds: 10 - replicaCount: 1 - resources: {} - securityContext: {} - service: - port: 80 - type: ClusterIP - tolerations: [] diff --git a/infra/feast-helm-operator/config/samples/kustomization.yaml b/infra/feast-helm-operator/config/samples/kustomization.yaml deleted file mode 100644 index 8a8cf497ead..00000000000 --- a/infra/feast-helm-operator/config/samples/kustomization.yaml +++ /dev/null @@ -1,4 +0,0 @@ -## Append samples of your project ## -resources: -- charts_v1alpha1_feastfeatureserver.yaml -#+kubebuilder:scaffold:manifestskustomizesamples diff --git a/infra/feast-helm-operator/config/scorecard/bases/config.yaml b/infra/feast-helm-operator/config/scorecard/bases/config.yaml deleted file mode 100644 index c77047841ed..00000000000 --- a/infra/feast-helm-operator/config/scorecard/bases/config.yaml +++ /dev/null @@ -1,7 +0,0 @@ -apiVersion: scorecard.operatorframework.io/v1alpha3 -kind: Configuration -metadata: - name: config -stages: -- parallel: true - tests: [] diff --git a/infra/feast-helm-operator/config/scorecard/kustomization.yaml b/infra/feast-helm-operator/config/scorecard/kustomization.yaml deleted file mode 100644 index 50cd2d084eb..00000000000 --- a/infra/feast-helm-operator/config/scorecard/kustomization.yaml +++ /dev/null @@ -1,16 +0,0 @@ -resources: -- bases/config.yaml -patchesJson6902: -- path: patches/basic.config.yaml - target: - group: scorecard.operatorframework.io - version: v1alpha3 - kind: Configuration - name: config -- path: patches/olm.config.yaml - target: - group: scorecard.operatorframework.io - version: v1alpha3 - kind: Configuration - name: config -#+kubebuilder:scaffold:patchesJson6902 diff --git a/infra/feast-helm-operator/config/scorecard/patches/basic.config.yaml b/infra/feast-helm-operator/config/scorecard/patches/basic.config.yaml deleted file mode 100644 index 78ad61a41bd..00000000000 --- a/infra/feast-helm-operator/config/scorecard/patches/basic.config.yaml +++ /dev/null @@ -1,10 +0,0 @@ -- op: add - path: /stages/0/tests/- - value: - entrypoint: - - scorecard-test - - basic-check-spec - image: quay.io/operator-framework/scorecard-test:v1.34.1 - labels: - suite: basic - test: basic-check-spec-test diff --git a/infra/feast-helm-operator/config/scorecard/patches/olm.config.yaml b/infra/feast-helm-operator/config/scorecard/patches/olm.config.yaml deleted file mode 100644 index 69dda63f2eb..00000000000 --- a/infra/feast-helm-operator/config/scorecard/patches/olm.config.yaml +++ /dev/null @@ -1,50 +0,0 @@ -- op: add - path: /stages/0/tests/- - value: - entrypoint: - - scorecard-test - - olm-bundle-validation - image: quay.io/operator-framework/scorecard-test:v1.34.1 - labels: - suite: olm - test: olm-bundle-validation-test -- op: add - path: /stages/0/tests/- - value: - entrypoint: - - scorecard-test - - olm-crds-have-validation - image: quay.io/operator-framework/scorecard-test:v1.34.1 - labels: - suite: olm - test: olm-crds-have-validation-test -- op: add - path: /stages/0/tests/- - value: - entrypoint: - - scorecard-test - - olm-crds-have-resources - image: quay.io/operator-framework/scorecard-test:v1.34.1 - labels: - suite: olm - test: olm-crds-have-resources-test -- op: add - path: /stages/0/tests/- - value: - entrypoint: - - scorecard-test - - olm-spec-descriptors - image: quay.io/operator-framework/scorecard-test:v1.34.1 - labels: - suite: olm - test: olm-spec-descriptors-test -- op: add - path: /stages/0/tests/- - value: - entrypoint: - - scorecard-test - - olm-status-descriptors - image: quay.io/operator-framework/scorecard-test:v1.34.1 - labels: - suite: olm - test: olm-status-descriptors-test diff --git a/infra/feast-helm-operator/helm-charts/feast-feature-server b/infra/feast-helm-operator/helm-charts/feast-feature-server deleted file mode 120000 index e432d2cba69..00000000000 --- a/infra/feast-helm-operator/helm-charts/feast-feature-server +++ /dev/null @@ -1 +0,0 @@ -../../charts/feast-feature-server \ No newline at end of file diff --git a/infra/feast-helm-operator/watches.yaml b/infra/feast-helm-operator/watches.yaml deleted file mode 100644 index bb400cb90d6..00000000000 --- a/infra/feast-helm-operator/watches.yaml +++ /dev/null @@ -1,6 +0,0 @@ -# Use the 'create api' subcommand to add watches to this file. -- group: charts.feast.dev - version: v1alpha1 - kind: FeastFeatureServer - chart: helm-charts/feast-feature-server -#+kubebuilder:scaffold:watch diff --git a/infra/scripts/release/files_to_bump.txt b/infra/scripts/release/files_to_bump.txt index 71cf1746b6d..1947078df9a 100644 --- a/infra/scripts/release/files_to_bump.txt +++ b/infra/scripts/release/files_to_bump.txt @@ -10,8 +10,6 @@ infra/charts/feast/README.md 11 68 69 infra/charts/feast-feature-server/Chart.yaml 5 infra/charts/feast-feature-server/README.md 3 infra/charts/feast-feature-server/values.yaml 12 -infra/feast-helm-operator/Makefile 6 -infra/feast-helm-operator/config/manager/kustomization.yaml 8 infra/feast-operator/Makefile 6 infra/feast-operator/config/manager/kustomization.yaml 8 infra/feast-operator/config/component_metadata.yaml 4