From adb35c823cde10b3dfe4dcc2f7cbac7422152463 Mon Sep 17 00:00:00 2001 From: Harri Lehtola Date: Sat, 21 Sep 2024 15:12:47 +0300 Subject: [PATCH 1/2] fix: Move @types packages to devDependencies in Feast UI Type declaration files are only used during development and not included in the runtime code, so they should be in devDependencies. We also shouldn't require dependent projects to install them by including them in peerDependencies. Signed-off-by: Harri Lehtola --- ui/package.json | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/ui/package.json b/ui/package.json index 3a609f3c83b..f2706d2cfb7 100644 --- a/ui/package.json +++ b/ui/package.json @@ -11,9 +11,6 @@ "@elastic/datemath": "^5.0.3", "@elastic/eui": "^55.0.1", "@emotion/react": "^11.7.1", - "@types/d3": "^7.1.0", - "@types/react": "^17.0.20", - "@types/react-dom": "^17.0.9", "d3": "^7.3.0", "inter-ui": "^3.19.3", "moment": "^2.29.1", @@ -32,11 +29,6 @@ "@elastic/datemath": "^5.0.3", "@elastic/eui": "^55.0.1", "@emotion/react": "^11.7.1", - "@types/d3": "^7.1.0", - "@types/jest": "^27.0.1", - "@types/node": "^16.7.13", - "@types/react": "^17.0.20", - "@types/react-dom": "^17.0.9", "d3": "^7.3.0", "inter-ui": "^3.19.3", "moment": "^2.29.1", @@ -95,6 +87,11 @@ "@testing-library/jest-dom": "^5.14.1", "@testing-library/react": "^12.0.0", "@testing-library/user-event": "^13.2.1", + "@types/d3": "^7.1.0", + "@types/jest": "^27.0.1", + "@types/node": "^16.7.13", + "@types/react": "^17.0.20", + "@types/react-dom": "^17.0.9", "msw": "^0.36.8", "protobufjs-cli": "^1.0.2", "react": "^17.0.2", From 5163451acd5e830a9d44b6ad30b6f76c28775736 Mon Sep 17 00:00:00 2001 From: Harri Lehtola Date: Sat, 21 Sep 2024 15:20:27 +0300 Subject: [PATCH 2/2] fix: Remove typescript from Feast UI peer dependencies TypeScript is a development dependency, so there is no need to require it from dependent projects via peer dependencies. Signed-off-by: Harri Lehtola --- ui/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/package.json b/ui/package.json index f2706d2cfb7..d95045ed9bf 100644 --- a/ui/package.json +++ b/ui/package.json @@ -21,7 +21,6 @@ "react-query": "^3.34.12", "react-router-dom": "6", "react-scripts": "^5.0.0", - "typescript": "^4.4.2", "use-query-params": "^1.2.3", "zod": "^3.11.6" },