From d89f1f66f5dc8c0f00b79ede0f321d0eafa15f4c Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Wed, 10 May 2023 19:52:16 -0700 Subject: [PATCH] Adding logging to the feature server when the registry is refreshed Signed-off-by: Danny Chiao --- sdk/python/feast/infra/registry/registry.py | 1 + sdk/python/feast/infra/registry/snowflake.py | 4 ++++ sdk/python/feast/infra/registry/sql.py | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/sdk/python/feast/infra/registry/registry.py b/sdk/python/feast/infra/registry/registry.py index 6f571a13b0c..1a72cbb4a58 100644 --- a/sdk/python/feast/infra/registry/registry.py +++ b/sdk/python/feast/infra/registry/registry.py @@ -848,6 +848,7 @@ def _get_registry_proto( assert isinstance(self.cached_registry_proto, RegistryProto) return self.cached_registry_proto + logger.info("Registry cache expired, so refreshing") registry_proto = self._registry_store.get_registry_proto() self.cached_registry_proto = registry_proto self.cached_registry_proto_created = datetime.utcnow() diff --git a/sdk/python/feast/infra/registry/snowflake.py b/sdk/python/feast/infra/registry/snowflake.py index 12682bdca2f..56c7bc1f659 100644 --- a/sdk/python/feast/infra/registry/snowflake.py +++ b/sdk/python/feast/infra/registry/snowflake.py @@ -1,3 +1,4 @@ +import logging import os import uuid from binascii import hexlify @@ -59,6 +60,8 @@ from feast.saved_dataset import SavedDataset, ValidationReference from feast.stream_feature_view import StreamFeatureView +logger = logging.getLogger(__name__) + class FeastMetadataKeys(Enum): LAST_UPDATED_TIMESTAMP = "last_updated_timestamp" @@ -174,6 +177,7 @@ def _refresh_cached_registry_if_necessary(self): ) if expired: + logger.info("Registry cache expired, so refreshing") self.refresh() def teardown(self): diff --git a/sdk/python/feast/infra/registry/sql.py b/sdk/python/feast/infra/registry/sql.py index 14a85e9ad9e..54ff7c9dc85 100644 --- a/sdk/python/feast/infra/registry/sql.py +++ b/sdk/python/feast/infra/registry/sql.py @@ -1,3 +1,4 @@ +import logging import uuid from datetime import datetime, timedelta from enum import Enum @@ -178,6 +179,8 @@ class FeastMetadataKeys(Enum): Column("last_updated_timestamp", BigInteger, nullable=False), ) +logger = logging.getLogger(__name__) + class SqlRegistryConfig(RegistryConfig): registry_type: StrictStr = "sql" @@ -256,6 +259,7 @@ def _refresh_cached_registry_if_necessary(self): ) if expired: + logger.info("Registry cache expired, so refreshing") self.refresh() def get_stream_feature_view(