From 5cbfad05a286aeb9c185c8b0273c619aedbc4086 Mon Sep 17 00:00:00 2001 From: gbmarc1 Date: Sat, 28 Jan 2023 19:32:21 -0500 Subject: [PATCH 1/2] fix: Add description attribute to the from_proto method Signed-off-by: gbmarc1 --- sdk/python/feast/field.py | 1 + sdk/python/tests/unit/test_feature.py | 3 +++ 2 files changed, 4 insertions(+) diff --git a/sdk/python/feast/field.py b/sdk/python/feast/field.py index 245bb24f52b..b07bddfeacb 100644 --- a/sdk/python/feast/field.py +++ b/sdk/python/feast/field.py @@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto): name=field_proto.name, dtype=from_value_type(value_type=value_type), tags=dict(field_proto.tags), + description=field_proto.description, ) @classmethod diff --git a/sdk/python/tests/unit/test_feature.py b/sdk/python/tests/unit/test_feature.py index a8cfeef3dab..29f869eabd2 100644 --- a/sdk/python/tests/unit/test_feature.py +++ b/sdk/python/tests/unit/test_feature.py @@ -27,3 +27,6 @@ def test_field_serialization_with_description(): assert serialized_field.description == expected_description assert field_from_feature.description == expected_description + + field = Field.from_proto(serialized_field) + assert field.description == expected_description From fbe907d4b700e71fb19adfc0e1f6efa3043a089d Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Mon, 30 Jan 2023 17:57:41 -0500 Subject: [PATCH 2/2] lint Signed-off-by: Danny Chiao --- sdk/python/tests/unit/test_feature.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/tests/unit/test_feature.py b/sdk/python/tests/unit/test_feature.py index 29f869eabd2..ca0dce44457 100644 --- a/sdk/python/tests/unit/test_feature.py +++ b/sdk/python/tests/unit/test_feature.py @@ -29,4 +29,4 @@ def test_field_serialization_with_description(): assert field_from_feature.description == expected_description field = Field.from_proto(serialized_field) - assert field.description == expected_description + assert field.description == expected_description