From 375ede36fdbe5e2370a693a60bf19a32ba19657c Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Fri, 12 Aug 2022 13:03:46 -0400 Subject: [PATCH 1/4] ci: Fix go unit tests failure Signed-off-by: Danny Chiao --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b48f261df3..97a6b3bc75 100644 --- a/Makefile +++ b/Makefile @@ -317,7 +317,7 @@ install-feast-ci-locally: # Needs feast package to setup the feature store # CGO flag is due to this issue: https://github.com/golang/go/wiki/InvalidFlag -test-go: compile-protos-go compile-go-lib install-feast-ci-locally +test-go: compile-protos-python compile-protos-go compile-go-lib install-feast-ci-locally CGO_LDFLAGS_ALLOW=".*" go test -tags cgo,ccalloc ./... format-go: From 42ebc7a2b77ea8060dbac6be647fbd37c38b9974 Mon Sep 17 00:00:00 2001 From: Kevin Zhang Date: Fri, 12 Aug 2022 11:04:47 -0700 Subject: [PATCH 2/4] Temporary fix? Signed-off-by: Kevin Zhang --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index b52453d43a..cd2497d191 100644 --- a/setup.py +++ b/setup.py @@ -60,7 +60,7 @@ "numpy>=1.22,<3", "pandas>=1.4.3,<2", "pandavro==1.5.*", # For some reason pandavro higher than 1.5.* only support pandas less than 1.3. - "protobuf>3.20,<4", + "protobuf>3.20", "proto-plus>=1.20.0,<2", "pyarrow>=4,<9", "pydantic>=1,<2", From 8ca783be74c67330dbd892a95b9733defe21ca7e Mon Sep 17 00:00:00 2001 From: Kevin Zhang Date: Fri, 12 Aug 2022 11:11:59 -0700 Subject: [PATCH 3/4] Fix Signed-off-by: Kevin Zhang --- Makefile | 2 +- setup.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 97a6b3bc75..f27050d8ef 100644 --- a/Makefile +++ b/Makefile @@ -304,7 +304,7 @@ install-go-ci-dependencies: python -m pip install pybindgen==0.22.0 protobuf==3.20.1 install-protoc-dependencies: - pip install grpcio-tools==1.47.0 mypy-protobuf==3.1.0 + pip install --ignore-installed protobuf grpcio-tools==1.47.0 mypy-protobuf==3.1.0 compile-protos-go: install-go-proto-dependencies install-protoc-dependencies python setup.py build_go_protos diff --git a/setup.py b/setup.py index cd2497d191..b52453d43a 100644 --- a/setup.py +++ b/setup.py @@ -60,7 +60,7 @@ "numpy>=1.22,<3", "pandas>=1.4.3,<2", "pandavro==1.5.*", # For some reason pandavro higher than 1.5.* only support pandas less than 1.3. - "protobuf>3.20", + "protobuf>3.20,<4", "proto-plus>=1.20.0,<2", "pyarrow>=4,<9", "pydantic>=1,<2", From 06362c64364612cee35b2ef4cc6cee9454be83aa Mon Sep 17 00:00:00 2001 From: Kevin Zhang Date: Fri, 12 Aug 2022 11:18:27 -0700 Subject: [PATCH 4/4] Fix Signed-off-by: Kevin Zhang --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f27050d8ef..8f1be59c73 100644 --- a/Makefile +++ b/Makefile @@ -317,7 +317,7 @@ install-feast-ci-locally: # Needs feast package to setup the feature store # CGO flag is due to this issue: https://github.com/golang/go/wiki/InvalidFlag -test-go: compile-protos-python compile-protos-go compile-go-lib install-feast-ci-locally +test-go: compile-protos-go compile-protos-python compile-go-lib install-feast-ci-locally CGO_LDFLAGS_ALLOW=".*" go test -tags cgo,ccalloc ./... format-go: