From 06a4bfd998fe4d141c060c0010101544055fd3a4 Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Sun, 7 Aug 2022 09:19:11 -0500 Subject: [PATCH 1/2] chore: Fix error where all calls report is_test as true because typeguard pulls in unittest Signed-off-by: Danny Chiao --- sdk/python/feast/usage.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sdk/python/feast/usage.py b/sdk/python/feast/usage.py index 5e78aa52d2..f667c68694 100644 --- a/sdk/python/feast/usage.py +++ b/sdk/python/feast/usage.py @@ -29,6 +29,7 @@ import requests +from feast import flags_helper from feast.constants import DEFAULT_FEAST_USAGE_VALUE, FEAST_USAGE from feast.version import get_version @@ -168,11 +169,13 @@ def _set_installation_id(): def _export(event: typing.Dict[str, typing.Any]): + print(f"DANNY_{event}") _executor.submit(requests.post, USAGE_ENDPOINT, json=event, timeout=30) def _produce_event(ctx: UsageContext): - is_test = bool({"pytest", "unittest"} & sys.modules.keys()) + # Cannot check for unittest because typeguard pulls in unittest + is_test = flags_helper.is_test() or bool({"pytest"} & sys.modules.keys()) event = { "timestamp": datetime.utcnow().isoformat(), "is_test": is_test, From 113e8929f6490686bc402aa4ee0f095d9dd01c06 Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Sun, 7 Aug 2022 09:21:11 -0500 Subject: [PATCH 2/2] fix Signed-off-by: Danny Chiao --- sdk/python/feast/usage.py | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/python/feast/usage.py b/sdk/python/feast/usage.py index f667c68694..9791f86c27 100644 --- a/sdk/python/feast/usage.py +++ b/sdk/python/feast/usage.py @@ -169,7 +169,6 @@ def _set_installation_id(): def _export(event: typing.Dict[str, typing.Any]): - print(f"DANNY_{event}") _executor.submit(requests.post, USAGE_ENDPOINT, json=event, timeout=30)