chore: Make Feast UI importable as a NPM Module by tonyhschu · Pull Request #2370 · feast-dev/feast

tonyhschu · 2022-03-05T21:46:23Z

What this PR does / why we need it:
Makes the Feast UI importable as a NPM Module. This will make it easier for customers that want to extend Feast UI to have maintain their own repo while still consuming our changes.

Which issue(s) this PR fixes:

Fixes #

codecov-commenter · 2022-03-05T21:49:51Z

Codecov Report

Merging #2370 (a58c59c) into master (c2389da) will decrease coverage by 28.34%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2370       +/-   ##
===========================================
- Coverage   85.47%   57.12%   -28.35%     
===========================================
  Files         122      122               
  Lines       10714    10704       -10     
===========================================
- Hits         9158     6115     -3043     
- Misses       1556     4589     +3033

Flag	Coverage Δ
integrationtests	`?`
unittests	`57.12% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../integration/online_store/test_universal_online.py	`14.35% <0.00%> (-82.81%)`	⬇️
.../integration/online_store/test_online_retrieval.py	`17.39% <0.00%> (-82.61%)`	⬇️
sdk/python/tests/utils/online_read_write_test.py	`20.68% <0.00%> (-79.32%)`	⬇️
...fline_store/test_universal_historical_retrieval.py	`23.50% <0.00%> (-76.50%)`	⬇️
sdk/python/feast/wait.py	`23.52% <0.00%> (-70.59%)`	⬇️
sdk/python/feast/infra/online_stores/redis.py	`27.04% <0.00%> (-69.19%)`	⬇️
...gration/registration/test_feature_service_apply.py	`31.25% <0.00%> (-68.75%)`	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	`33.87% <0.00%> (-66.13%)`	⬇️
sdk/python/tests/data/data_creator.py	`34.78% <0.00%> (-65.22%)`	⬇️
...dk/python/tests/integration/e2e/test_validation.py	`35.18% <0.00%> (-64.82%)`	⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2389da...a58c59c. Read the comment docs.

adchia · 2022-03-11T15:49:40Z

is this intentional? seems not used so maybe can revert

This is intentional. This enables the user to turn on this on as a prop on <FeastUI> i.e.

<FeastUI feastUIConfigs={{ featureFlags: { enabledFeatureStatistics: true }, }} />

This already works. I need to document this better hahaha.

adchia · 2022-03-11T15:50:59Z

does this let users flip it on / off in the top level FeastUI component?

See this comment: #2370 (comment)

woop · 2022-03-13T00:35:36Z

Is this really a "feature"? Seems more like a chore or housekeeping. Bit of a gray area.

tonyhschu · 2022-03-13T02:13:28Z

I didn't know what to pick. Happy to go with whatever @adchia thinks is more appropriate.

adchia · 2022-03-14T17:25:15Z

Couple things to fix:

Make the version 0.19.4 (our next patch release) + publish this
In a followup PR, add documentation about publishing this package (add me to the feast org too)

adchia · 2022-03-14T17:25:56Z

Also sign the commits

adchia · 2022-03-14T17:28:45Z

Also: revert the deleting of the App.test.tsx

adchia · 2022-03-14T17:29:20Z

convert it from feat: -> housekeeping:

woop · 2022-03-14T20:28:56Z

Make the version 0.19.4 (our next patch release) + publish this

Any reason we can't do the following instead

Make the packages.json version the same as other versions on master (0.19.0) and merge this PR in
Add packages.json to https://github.com/feast-dev/feast/blob/master/infra/scripts/release/files_to_bump.txt
Backport both (1) and (2) to v0.19-branch
Change the version in packages.json on the v0.19-branch to 0.19.3
Cut release on v0.19-branch, which will automatically bump packages.json to 0.19.4 before publishing
(eventually) Cut release on master, which will automatically bump packages.json to 0.20.0 before publishing

woop · 2022-03-21T23:17:32Z

@adchia @tonyhschu next steps here?

tonyhschu · 2022-03-22T15:15:38Z

Hey @woop this is on me. I can follow the scheme you laid out above. I owe @adchia a couple other small changes - eg documenting how to publish to NPM.

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

adchia

/lgtm

feast-ci-bot · 2022-03-23T03:08:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, tonyhschu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot added do-not-merge/work-in-progress size/XXL labels Mar 5, 2022

tonyhschu changed the title ~~Make Feast UI importable~~ feat: Make Feast UI importable as a NPM Module Mar 5, 2022

tonyhschu force-pushed the tchu-feast-ui-as-npm-module branch 2 times, most recently from b5315b5 to a378d82 Compare March 6, 2022 22:33

adchia reviewed Mar 8, 2022

View reviewed changes

Comment thread ui/.gitignore Outdated

Comment thread ui/package.json Outdated

adchia reviewed Mar 11, 2022

View reviewed changes

tonyhschu force-pushed the tchu-feast-ui-as-npm-module branch from ede4141 to 887c892 Compare March 13, 2022 00:33

tonyhschu marked this pull request as ready for review March 13, 2022 00:34

tonyhschu requested a review from a team as a code owner March 13, 2022 00:34

tonyhschu requested review from mavysavydav and removed request for a team March 13, 2022 00:34

feast-ci-bot removed the do-not-merge/work-in-progress label Mar 13, 2022

github-actions Bot assigned achals Mar 13, 2022

tonyhschu changed the title ~~feat: Make Feast UI importable as a NPM Module~~ housekeeping: Make Feast UI importable as a NPM Module Mar 22, 2022

tonyhschu added 5 commits March 22, 2022 11:20

Make FeastUI publishable as NPM Module

dd74834

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Fixes tests

ba69afa

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Add Feature Flags as Config

73cdc1e

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Update package.json

ae718db

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Make where to fetch projects configurable.

9190959

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

tonyhschu added 5 commits March 22, 2022 11:20

Match Feast's License

2dd0e83

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Better error messages for missing Project List

9e6835e

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Fix typo and remove gitignore

dcf08fa

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Add customization instructions to the README

d218655

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

Add back tests and document publishing

a58c59c

Signed-off-by: Tony Chu <tonyhschu@gmail.com>

tonyhschu force-pushed the tchu-feast-ui-as-npm-module branch from 887c892 to a58c59c Compare March 22, 2022 18:21

tonyhschu changed the title ~~housekeeping: Make Feast UI importable as a NPM Module~~ chore: Make Feast UI importable as a NPM Module Mar 22, 2022

adchia approved these changes Mar 23, 2022

View reviewed changes

feast-ci-bot assigned adchia Mar 23, 2022

feast-ci-bot added the lgtm label Mar 23, 2022

feast-ci-bot added the approved label Mar 23, 2022

feast-ci-bot merged commit 45db6dc into feast-dev:master Mar 23, 2022

adchia linked an issue Apr 21, 2022 that may be closed by this pull request

Feast Web UI #2353

Open

14 tasks

Conversation

tonyhschu commented Mar 5, 2022

Uh oh!

codecov-commenter commented Mar 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

adchia Mar 11, 2022

Choose a reason for hiding this comment

Uh oh!

tonyhschu Mar 12, 2022

Choose a reason for hiding this comment

Uh oh!

adchia Mar 11, 2022

Choose a reason for hiding this comment

Uh oh!

tonyhschu Mar 12, 2022

Choose a reason for hiding this comment

Uh oh!

tonyhschu Mar 12, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

woop commented Mar 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonyhschu commented Mar 13, 2022

Uh oh!

adchia commented Mar 14, 2022

Uh oh!

adchia commented Mar 14, 2022

Uh oh!

adchia commented Mar 14, 2022

Uh oh!

adchia commented Mar 14, 2022

Uh oh!

woop commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

woop commented Mar 21, 2022

Uh oh!

tonyhschu commented Mar 22, 2022

Uh oh!

adchia left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Mar 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Mar 5, 2022 •

edited

Loading

woop commented Mar 13, 2022 •

edited

Loading

woop commented Mar 14, 2022 •

edited

Loading