From c5cc62c0c4d8ed8f48ce6b83969cc98d3df3f0ec Mon Sep 17 00:00:00 2001 From: Willem Pienaar Date: Sun, 15 Nov 2020 12:45:43 +0800 Subject: [PATCH 1/3] Fix connection resets in Maven Signed-off-by: Willem Pienaar --- .github/workflows/complete.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/complete.yml b/.github/workflows/complete.yml index 778be2fc200..d970cb72927 100644 --- a/.github/workflows/complete.yml +++ b/.github/workflows/complete.yml @@ -153,9 +153,10 @@ jobs: maven-version: 3.6.3 - name: build-jar env: - # Try to add retries to prevent download failure + # Try to add retries to prevent connection resets # https://github.community/t/getting-maven-could-not-transfer-artifact-with-500-error-when-using-github-actions/17570 - MAVEN_OPTS: -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 + # https://github.com/actions/virtual-environments/issues/1499#issuecomment-718396233 + MAVEN_OPTS: -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false run: make build-java-no-tests REVISION=${GITHUB_SHA} - name: copy to gs run: gsutil cp ./spark/ingestion/target/feast-ingestion-spark-${GITHUB_SHA}.jar gs://feast-jobs/spark/ingestion/ From c843faa82e7181e535908abbee5eaf43ce990f0d Mon Sep 17 00:00:00 2001 From: Willem Pienaar Date: Sun, 15 Nov 2020 13:07:27 +0800 Subject: [PATCH 2/3] Enable debug mode --- .github/workflows/complete.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/complete.yml b/.github/workflows/complete.yml index d970cb72927..b0993e245de 100644 --- a/.github/workflows/complete.yml +++ b/.github/workflows/complete.yml @@ -156,7 +156,7 @@ jobs: # Try to add retries to prevent connection resets # https://github.community/t/getting-maven-could-not-transfer-artifact-with-500-error-when-using-github-actions/17570 # https://github.com/actions/virtual-environments/issues/1499#issuecomment-718396233 - MAVEN_OPTS: -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false + MAVEN_OPTS: -X -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false run: make build-java-no-tests REVISION=${GITHUB_SHA} - name: copy to gs run: gsutil cp ./spark/ingestion/target/feast-ingestion-spark-${GITHUB_SHA}.jar gs://feast-jobs/spark/ingestion/ From 1a23de0032e3590ff2dde86c6acc94f46dc25a4b Mon Sep 17 00:00:00 2001 From: Willem Pienaar Date: Sun, 15 Nov 2020 13:13:16 +0800 Subject: [PATCH 3/3] Move debug flag to MAVEN_EXTRA_OPTS --- .github/workflows/complete.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/complete.yml b/.github/workflows/complete.yml index b0993e245de..99f565269ad 100644 --- a/.github/workflows/complete.yml +++ b/.github/workflows/complete.yml @@ -156,7 +156,8 @@ jobs: # Try to add retries to prevent connection resets # https://github.community/t/getting-maven-could-not-transfer-artifact-with-500-error-when-using-github-actions/17570 # https://github.com/actions/virtual-environments/issues/1499#issuecomment-718396233 - MAVEN_OPTS: -X -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false + MAVEN_OPTS: -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false + MAVEN_EXTRA_OPTS: -X run: make build-java-no-tests REVISION=${GITHUB_SHA} - name: copy to gs run: gsutil cp ./spark/ingestion/target/feast-ingestion-spark-${GITHUB_SHA}.jar gs://feast-jobs/spark/ingestion/