From 8b62d9c1419a3b2612d689455979c45ce70784ec Mon Sep 17 00:00:00 2001 From: Terence Date: Thu, 17 Sep 2020 11:53:37 +0800 Subject: [PATCH] Update tests with bool list --- sdk/python/tests/dataframes.py | 5 +++++ sdk/python/tests/test_client.py | 4 +--- .../all_types_parquet/all_types_parquet.yaml | 2 ++ tests/e2e/redis/basic-ingest-redis-serving.py | 17 ++++++++--------- tests/load/ingest.py | 4 ++++ 5 files changed, 20 insertions(+), 12 deletions(-) diff --git a/sdk/python/tests/dataframes.py b/sdk/python/tests/dataframes.py index a50aa89810c..b07a557c6cc 100644 --- a/sdk/python/tests/dataframes.py +++ b/sdk/python/tests/dataframes.py @@ -116,5 +116,10 @@ np.array([b"one", b"two", b"three"]), np.array([b"one", b"two", b"three"]), ], + "bool_list_feature": [ + [True, False, True], + [True, False, True], + [True, False, True], + ], } ) diff --git a/sdk/python/tests/test_client.py b/sdk/python/tests/test_client.py index b9ef22b95b0..be8bc786794 100644 --- a/sdk/python/tests/test_client.py +++ b/sdk/python/tests/test_client.py @@ -986,9 +986,7 @@ def test_feature_set_types_success(self, test_client, dataframe, mocker): Feature(name="int32_list_feature", dtype=ValueType.INT32_LIST), Feature(name="string_list_feature", dtype=ValueType.STRING_LIST), Feature(name="bytes_list_feature", dtype=ValueType.BYTES_LIST), - # Feature(name="bool_list_feature", - # dtype=ValueType.BOOL_LIST), # TODO: Add support for this - # type again https://github.com/feast-dev/feast/issues/341 + Feature(name="bool_list_feature", dtype=ValueType.BOOL_LIST), Feature(name="double_list_feature", dtype=ValueType.DOUBLE_LIST), ], max_age=Duration(seconds=3600), diff --git a/tests/e2e/redis/all_types_parquet/all_types_parquet.yaml b/tests/e2e/redis/all_types_parquet/all_types_parquet.yaml index fa95ce13be0..b054913c65a 100644 --- a/tests/e2e/redis/all_types_parquet/all_types_parquet.yaml +++ b/tests/e2e/redis/all_types_parquet/all_types_parquet.yaml @@ -29,4 +29,6 @@ spec: valueType: STRING_LIST - name: bytes_list_feature_parquet valueType: BYTES_LIST + - name: bool_list_feature_parquet + valueType: BOOL_LIST maxAge: 0s diff --git a/tests/e2e/redis/basic-ingest-redis-serving.py b/tests/e2e/redis/basic-ingest-redis-serving.py index 92134af6daa..853da9f5290 100644 --- a/tests/e2e/redis/basic-ingest-redis-serving.py +++ b/tests/e2e/redis/basic-ingest-redis-serving.py @@ -886,12 +886,11 @@ def all_types_dataframe(): np.array([b"one", b"two", b"three"]), np.array([b"one", b"two", b"three"]), ], - # "bool_list_feature": [ - # np.array([True, False, True]), - # np.array([True, False, True]), - # np.array([True, False, True]), - # ], - # TODO: https://github.com/feast-dev/feast/issues/341 + "bool_list_feature": [ + [True, False, True], + [True, False, True], + [True, False, True], + ], } ) @@ -918,6 +917,7 @@ def test_all_types_register_feature_set_success(client): Feature(name="int32_list_feature", dtype=ValueType.INT32_LIST), Feature(name="string_list_feature", dtype=ValueType.STRING_LIST), Feature(name="bytes_list_feature", dtype=ValueType.BYTES_LIST), + Feature(name="bool_list_feature", dtype=ValueType.BOOL_LIST), ], max_age=Duration(seconds=3600), ) @@ -970,6 +970,7 @@ def test_all_types_retrieve_online_success(client, all_types_dataframe): "string_list_feature", "bytes_list_feature", "double_list_feature", + "bool_list_feature", ] def try_get_features(): @@ -1179,12 +1180,10 @@ def all_types_parquet_file(): "bytes_list_feature_parquet": [ np.array([b"one", b"two", b"three"]) for _ in range(COUNT) ], + "bool_list_feature_parquet": [[True, False, True] for _ in range(COUNT)], } ) - # TODO: Boolean list is not being tested. - # https://github.com/feast-dev/feast/issues/341 - file_path = os.path.join(tempfile.mkdtemp(), "all_types.parquet") df.to_parquet(file_path, allow_truncated_timestamps=True) return file_path diff --git a/tests/load/ingest.py b/tests/load/ingest.py index cf6e8d7648a..24100d044b3 100644 --- a/tests/load/ingest.py +++ b/tests/load/ingest.py @@ -47,6 +47,9 @@ "bytes_list_feature": [ np.array([b"one", b"two", b"three"]) for _ in range(number_of_entities) ], + "bool_list_feature": [ + [True, False, True] for _ in range(number_of_entities) + ], } ) @@ -67,6 +70,7 @@ Feature(name="int32_list_feature", dtype=ValueType.INT32_LIST), Feature(name="string_list_feature", dtype=ValueType.STRING_LIST), Feature(name="bytes_list_feature", dtype=ValueType.BYTES_LIST), + Feature(name="bool_list_feature", dtype=ValueType.BOOL_LIST), ], )