Skip to content

Remove numpy <1.25 dependency in setup.py #4084

Closed

Description

@softwareentrepreneer

In setup.py, I can see that the dependency for pandas has already been updated from
"pandas>=1.4.3,<2" (which is still in the current PyPI version) to "pandas>=1.4.3,<3", but numpy hasn't, which will break the installation if I am using e.g. pandas 2.2.1, that requires numpy (>=1.26.0,<2)

Problem

"numpy>=1.22,<1.25"

Solution

"numpy>=1.22,<2"

Steps to reproduce

poetry add git+https://github.com/feast-dev/feast.git

Activity

  1. tokoko commented on Apr 9, 2024

    @tokoko
    Collaborator

    @softwareentrepreneer thanks, looks like the pin was added simply to get rid of some deprecation warnings, so this shouldn't be an issue. Would you like to open a PR?

  2. softwareentrepreneer commented on Apr 9, 2024

    @softwareentrepreneer
    ContributorAuthor

    @softwareentrepreneer thanks, looks like the pin was added simply to get rid of some deprecation warnings, so this shouldn't be an issue. Would you like to open a PR?

    sure, here is the PR, thanks for the quick response

  3. added a commit that references this issue on Apr 19, 2024
    2ba71ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions