Skip to content

to_snowflake for generation of offline features does nothing if the table exists in Snowflake. #3447

Closed

Description

@sfc-gh-rsaxena

Is your feature request related to a problem? Please describe.
to_Snowflake fires CREATE TABLE IF NOT EXISTS to create a new table to store offline features. It does not overwrite or append into the existing table. It has its benefits, but could also be very misleading since it doesn’t throw any warning, messages or anything to inform the user that it didn’t write new records to the table.

fs.get_historical_features(features=feature_service, entity_df=customers).to_snowflake(table_name='historical_features')
Describe the solution you'd like
There should be a Warning message informing the user that the table with the same name exist and no action will be taken.

Describe alternatives you've considered
Couple of ways to make it work every time you need to get most recent data is to either programatically change the name and store in a new table each time or delete existing table and then recreate the table.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions