Skip to content

feast[snowflake] demo workflow fails to get historical features through sql. get_table_query_string not implemented #3301

@amithadiraju1694

Description

@amithadiraju1694

I'm trying to run 'feast[snowflake]' demo workflow ( through a trial snowflake account ) from here: Running on Snowflake/AWS/GCP by executing workflow file as python3 test_workflow.py.

Most of the steps work fine, but the execution fails at this function : fetch_historical_features_entity_sql(store, for_batch_scoring=False).

Expected Behavior

fetch_historical_features_entity_sql(store, for_batch_scoring=False) should work fine and display a pandas data frame with 5 rows.

Current Behavior

All Steps Work Fine, starting from feast apply

--- Historical features for training (all entities in a window using SQL entity dataframe) --- Generating training data for all entities in a time window Traceback (most recent call last): File "/Users/aadir00/Desktop/Amith/Feast_Demo/able_parakeet/test_workflow.py", line 187, in <module> run_demo() File "/Users/aadir00/Desktop/Amith/Feast_Demo/able_parakeet/test_workflow.py", line 29, in run_demo fetch_historical_features_entity_sql(store, for_batch_scoring=False) File "/Users/aadir00/Desktop/Amith/Feast_Demo/able_parakeet/test_workflow.py", line 102, in fetch_historical_features_entity_sql FROM {store.list_data_sources()[-1].get_table_query_string()} File "/Users/aadir00/Albvenv_feast/lib/python3.9/site-packages/typeguard/__init__.py", line 1033, in wrapper retval = func(*args, **kwargs) File "/Users/aadir00/Albvenv_feast/lib/python3.9/site-packages/feast/data_source.py", line 605, in get_table_query_string raise NotImplementedError NotImplementedError

Steps to reproduce

pip3 install 'feast[snowflake]'

feast init -t snowflake .... Snowflake creds

'cd project_folder python3 test_workflow.py`

Specifications

  • Version:
    Python: 3.9.6 and 3.8.10
    Pip: 21.2.4 and 21.0.1
    Feast: 0.26.0

  • Platform: MacBook Pro 16, M1 Chip

  • Subsystem: NA

Possible Solution

Update source code at feast/data_source.py to implement loading data from sql string.

P.S: When I comment out the two functions fetch_historical_features_entity_sql(store, for_batch_scoring=False) and fetch_historical_features_entity_sql(store, for_batch_scoring=True) remaining steps in the test_workflow.py works fine and as expected.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions