feast apply broken with 0.15.* if the registry already exists #2086

Activity

1. MattDelac

   added

   kind/bug

   priority/p0Highest priorityHighest priority

   on Nov 23, 2021
2. github-actions

   assigned

   felixwang9817

   on Nov 23, 2021
3. adchia

   added

   priority/p1

   and removed

   priority/p0Highest priorityHighest priority

   on Nov 24, 2021
4. adchia commented on Nov 24, 2021

   

   adchia

   on Nov 24, 2021

   Collaborator

   More actions

   There was a fix shipped to better handle entityless feature views, but seems like we're having trouble reproducing this bug.

   Can you try again at HEAD and see if this still reproduces?
5. MattDelac commented on Nov 25, 2021

   

   MattDelac

   on Nov 25, 2021

   Last edited by MattDelac

   CollaboratorAuthor

   More actions

   There was a fix shipped to better handle entityless feature views, but seems like we're having trouble reproducing this bug.

   Can you try again at HEAD and see if this still reproduces?

   I get another issue that does not seem relevant to this ticket
   

   Was using the following commit 54d0f3a1842c7613aaffcd67512e08ab9b688740

   "feast[gcp] @ git+https://github.com/feast-dev/feast.git@54d0f3a1842c7613aaffcd67512e08ab9b688740#subdirectory=sdk/python&egg=feast",
6. felixwang9817 commented on Nov 25, 2021

   

   felixwang9817

   on Nov 25, 2021

   Collaborator

   More actions

   hey @MattDelac, this issue looks like it might be related to #2038 and #2063

   maybe try pip installing tensorflow-metadata and trying again?

   👀React with 👀1Reacted by Matt Delacour
7. MattDelac commented on Nov 29, 2021

   

   MattDelac

   on Nov 29, 2021

   CollaboratorAuthor

   More actions

   hey @MattDelac, this issue looks like it might be related to #2038 and #2063

   maybe try pip installing tensorflow-metadata and trying again?

   It was already installed tensorflow-metadata==1.4.0, so it did not change anything
8. MattDelac commented on Dec 1, 2021

   

   MattDelac

   on Dec 1, 2021

   CollaboratorAuthor

   More actions

   hey @MattDelac, this issue looks like it might be related to #2038 and #2063

   maybe try pip installing tensorflow-metadata and trying again?

   I tried all versions of tensorflow-metadata from 1.2.0 to 1.5.0

   Always get the same error. Would today be a good time to pair on this issue ?
9. MattDelac commented on Dec 2, 2021

   

   MattDelac

   on Dec 2, 2021

   CollaboratorAuthor

   More actions

   So the problem is that I create a child class from the Feast FeatureView class. I do so in order to add Shopify specifics.

   Since feast==0.15.0, the cls argument passed to the classmethod from_proto() was the child class instead of the parent class. Thus, the from_proto() method was broken when it was trying to create a new FeatureView object.

   The solution is to override this method class and explicitly return the one coming from the parent class (see code below)

   from feast.feature_view import FeatureView as FeastFeatureView
   
   class FeatureView(FeastFeatureView):
       def __init__(
           self,
           name: str,
           entity: str,
           owner: str,
           features: List[Feature],
           batch_source: CustomSource,
           ttl: Optional[timedelta] = None,
       ):
           super().__init__(
               name=name,
               entities=[entity],
               features=features,
               batch_source=batch_source,
               ttl=ttl,
               tags={...}
           )
   
       @classmethod
       def from_proto(self, feature_view_proto):
           return FeastFeatureView.from_proto(feature_view_proto)
10. MattDelac

    closed this as completedon Dec 2, 2021