From 9e9e290f4a02aaeecfb5f605595c74b6804457a8 Mon Sep 17 00:00:00 2001 From: Youngrok Bahn Date: Sat, 21 Aug 2021 01:28:52 +0900 Subject: [PATCH 1/2] Update feature_view.py check if the value of batch_source_proto is None. --- sdk/python/feast/feature_view.py | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py index a833c7a5e5b..444bd35c2e1 100644 --- a/sdk/python/feast/feature_view.py +++ b/sdk/python/feast/feature_view.py @@ -218,6 +218,7 @@ def to_proto(self) -> FeatureViewProto: ttl_duration.FromTimedelta(self.ttl) batch_source_proto = self.batch_source.to_proto() + if batch_source_proto is not None: batch_source_proto.data_source_class_type = f"{self.batch_source.__class__.__module__}.{self.batch_source.__class__.__name__}" stream_source_proto = None From b5648f0cb6109594fcc8881237ddd583960d244f Mon Sep 17 00:00:00 2001 From: Youngrok Bahn Date: Tue, 24 Aug 2021 23:31:27 +0900 Subject: [PATCH 2/2] Update feature_view.py --- sdk/python/feast/feature_view.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py index 444bd35c2e1..a02023f0c52 100644 --- a/sdk/python/feast/feature_view.py +++ b/sdk/python/feast/feature_view.py @@ -219,7 +219,7 @@ def to_proto(self) -> FeatureViewProto: batch_source_proto = self.batch_source.to_proto() if batch_source_proto is not None: - batch_source_proto.data_source_class_type = f"{self.batch_source.__class__.__module__}.{self.batch_source.__class__.__name__}" + batch_source_proto.data_source_class_type = f"{self.batch_source.__class__.__module__}.{self.batch_source.__class__.__name__}" stream_source_proto = None if self.stream_source: