Skip to content

Commit fefc7d5

Browse files
committed
Fix makefile building images tagged latest instead of expected Git SHA by backport master makefile
1 parent 56ed019 commit fefc7d5

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/complete.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
runs-on: [ubuntu-latest]
7070
steps:
7171
- uses: actions/checkout@v2
72-
- name: install dependencies
72+
- name: Lint versions throughout repo
7373
run: make lint-versions
7474

7575
unit-test-java:

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ build-push-docker:
113113
@$(MAKE) build-docker registry=$(REGISTRY) version=$(VERSION)
114114
@$(MAKE) push-core-docker registry=$(REGISTRY) version=$(VERSION)
115115
@$(MAKE) push-serving-docker registry=$(REGISTRY) version=$(VERSION)
116-
@$(MAKE) push-ci-docker registry=$(REGISTRY)
116+
@$(MAKE) push-ci-docker registry=$(REGISTRY) version=$(VERSION)
117117

118118
build-docker: build-core-docker build-serving-docker build-ci-docker
119119

@@ -124,7 +124,7 @@ push-serving-docker:
124124
docker push $(REGISTRY)/feast-serving:$(VERSION)
125125

126126
push-ci-docker:
127-
docker push $(REGISTRY)/feast-ci:latest
127+
docker push $(REGISTRY)/feast-ci:$(VERSION)
128128

129129
push-jupyter-docker:
130130
docker push $(REGISTRY)/feast-jupyter:$(VERSION)
@@ -136,7 +136,7 @@ build-serving-docker:
136136
docker build -t $(REGISTRY)/feast-serving:$(VERSION) -f infra/docker/serving/Dockerfile .
137137

138138
build-ci-docker:
139-
docker build -t $(REGISTRY)/feast-ci:latest -f infra/docker/ci/Dockerfile .
139+
docker build -t $(REGISTRY)/feast-ci:$(VERSION) -f infra/docker/ci/Dockerfile .
140140

141141
build-jupyter-docker:
142142
docker build -t $(REGISTRY)/feast-jupyter:$(VERSION) -f infra/docker/jupyter/Dockerfile .
@@ -184,4 +184,4 @@ lint-versions:
184184
./infra/scripts/validate-version-consistency.sh
185185

186186
test-load:
187-
./infra/scripts/test-load.sh $(GIT_SHA)
187+
./infra/scripts/test-load.sh $(GIT_SHA)

0 commit comments

Comments
 (0)