fix: move mutable class attrs to __init__ in FaissOnlineStore

rpathade · rpathade · commit fe8c27046b0d · 2026-04-01T22:49:05.000-07:00
Signed-off-by: RutujaPathade &lt;73137503+RutujaPathade@users.noreply.github.com&gt;
diff --git a/sdk/python/feast/infra/online_stores/faiss_online_store.py b/sdk/python/feast/infra/online_stores/faiss_online_store.py
@@ -66,9 +66,7 @@ def __init__(self):
         self._in_memory_stores: Dict[str, InMemoryStore] = {}
         self._config: Optional[FaissOnlineStoreConfig] = None
 
-    def _get_index(
-        self, table_key: str
-    ) -> Optional[faiss.IndexIVFFlat]:
+    def _get_index(self, table_key: str) -> Optional[faiss.IndexIVFFlat]:
         return self._indices.get(table_key)
 
     def update(
@@ -95,9 +93,7 @@ def update(
 
             if table_key not in self._indices or not partial:
                 quantizer = faiss.IndexFlatL2(dimension)
-                index = faiss.IndexIVFFlat(
-                    quantizer, dimension, self._config.nlist
-                )
+                index = faiss.IndexIVFFlat(quantizer, dimension, self._config.nlist)
                 index.train(
                     np.random.rand(self._config.nlist * 100, dimension).astype(
                         np.float32
@@ -202,13 +198,9 @@ def online_write_batch(
         ]
         mask = np.array(existing_indices) != -1
         if np.any(mask):
-            index.remove_ids(
-                np.array([idx for idx in existing_indices if idx != -1])
-            )
+            index.remove_ids(np.array([idx for idx in existing_indices if idx != -1]))
 
-        new_indices = np.arange(
-            index.ntotal, index.ntotal + len(feature_vectors_array)
-        )
+        new_indices = np.arange(index.ntotal, index.ntotal + len(feature_vectors_array))
         index.add(feature_vectors_array)
 
         for sk, idx in zip(serialized_keys, new_indices):
