Skip to content

Commit f41ab82

Browse files
committed
fix: Add hybrid to Go operator ValidOnlineStoreDBStorePersistenceTypes
The data source types test validates that Python ONLINE_STORE_CLASS_FOR_TYPE matches the Go operator's ValidOnlineStoreDBStorePersistenceTypes. This adds the hybrid type to both v1 and v1alpha1 API versions. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
1 parent 2213990 commit f41ab82

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

infra/feast-operator/api/v1/featurestore_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ type OnlineStoreFilePersistence struct {
371371
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
372372
type OnlineStoreDBStorePersistence struct {
373373
// Type of the persistence type you want to use.
374-
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus
374+
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid
375375
Type string `json:"type"`
376376
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
377377
SecretRef corev1.LocalObjectReference `json:"secretRef"`
@@ -396,6 +396,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
396396
"qdrant",
397397
"couchbase.online",
398398
"milvus",
399+
"hybrid",
399400
}
400401

401402
// LocalRegistryConfig configures the registry service

infra/feast-operator/api/v1alpha1/featurestore_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ type OnlineStoreFilePersistence struct {
371371
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
372372
type OnlineStoreDBStorePersistence struct {
373373
// Type of the persistence type you want to use.
374-
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus
374+
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid
375375
Type string `json:"type"`
376376
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
377377
SecretRef corev1.LocalObjectReference `json:"secretRef"`
@@ -396,6 +396,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
396396
"qdrant",
397397
"couchbase.online",
398398
"milvus",
399+
"hybrid",
399400
}
400401

401402
// LocalRegistryConfig configures the registry service

infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1322,6 +1322,7 @@ spec:
13221322
- qdrant
13231323
- couchbase.online
13241324
- milvus
1325+
- hybrid
13251326
type: string
13261327
required:
13271328
- secretRef
@@ -5358,6 +5359,8 @@ spec:
53585359
- qdrant
53595360
- couchbase.online
53605361
- milvus
5362+
- hybrid
5363+
- hybrid
53615364
type: string
53625365
required:
53635366
- secretRef
@@ -9521,6 +9524,7 @@ spec:
95219524
- qdrant
95229525
- couchbase.online
95239526
- milvus
9527+
- hybrid
95249528
type: string
95259529
required:
95269530
- secretRef
@@ -13557,6 +13561,8 @@ spec:
1355713561
- qdrant
1355813562
- couchbase.online
1355913563
- milvus
13564+
- hybrid
13565+
- hybrid
1356013566
type: string
1356113567
required:
1356213568
- secretRef

infra/feast-operator/dist/install.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,6 +1330,7 @@ spec:
13301330
- qdrant
13311331
- couchbase.online
13321332
- milvus
1333+
- hybrid
13331334
type: string
13341335
required:
13351336
- secretRef
@@ -5366,6 +5367,8 @@ spec:
53665367
- qdrant
53675368
- couchbase.online
53685369
- milvus
5370+
- hybrid
5371+
- hybrid
53695372
type: string
53705373
required:
53715374
- secretRef
@@ -9529,6 +9532,7 @@ spec:
95299532
- qdrant
95309533
- couchbase.online
95319534
- milvus
9535+
- hybrid
95329536
type: string
95339537
required:
95349538
- secretRef
@@ -13565,6 +13569,8 @@ spec:
1356513569
- qdrant
1356613570
- couchbase.online
1356713571
- milvus
13572+
- hybrid
13573+
- hybrid
1356813574
type: string
1356913575
required:
1357013576
- secretRef

0 commit comments

Comments
 (0)