fix: Fix handling of TTL in Go server (#3232)

wdhorton · web-flow · commit f020630c0144 · 2022-09-19T11:05:19.000-07:00
Fix handling of TTL in Go server

According to the FeatureView docstring, 'A ttl of 0 indicates that this group of features lives forever.'
However, the Go feature server doesn't currently respect this, returning OUTSIDE_MAX_AGE for FeatureViews
that have a TTL of 0. This fixes that issue by always returning false for checkOutsideTtl if the TTL
is 0.

Signed-off-by: William Horton &lt;william.horton@grandrounds.com&gt;

Signed-off-by: William Horton &lt;william.horton@grandrounds.com&gt;
diff --git a/go/internal/feast/onlineserving/serving.go b/go/internal/feast/onlineserving/serving.go
@@ -633,6 +633,9 @@ func getUniqueEntityRows(joinKeysProto []*prototypes.EntityKey) ([]*prototypes.E
 }
 
 func checkOutsideTtl(featureTimestamp *timestamppb.Timestamp, currentTimestamp *timestamppb.Timestamp, ttl *durationpb.Duration) bool {
+	if ttl.Seconds == 0 {
+		return false
+	}
 	return currentTimestamp.GetSeconds()-featureTimestamp.GetSeconds() > ttl.Seconds
 }
 

Original file line number	Diff line number	Diff line change
`@@ -633,6 +633,9 @@ func getUniqueEntityRows(joinKeysProto []prototypes.EntityKey) ([]prototypes.E`
`633`	`633`	`}`
`634`	`634`
`635`	`635`	`func checkOutsideTtl(featureTimestamp timestamppb.Timestamp, currentTimestamp timestamppb.Timestamp, ttl *durationpb.Duration) bool {`
	`636`	`+ if ttl.Seconds == 0 {`
	`637`	`+ return false`
	`638`	`+ }`
`636`	`639`	`return currentTimestamp.GetSeconds()-featureTimestamp.GetSeconds() > ttl.Seconds`
`637`	`640`	`}`
`638`	`641`