Skip to content

Commit ed4dad2

Browse files
authored
Fix typos in documentation (#698)
* Clean up documentation * Update feature-retrieval.md
1 parent aac9298 commit ed4dad2

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

docs/user-guide/feature-retrieval.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Historical feature retrieval can be done through either the Feast SDK or directl
5555
features = self._features + [self._target]
5656

5757
# Retrieve training dataset from Feast. The "entity_df" is a dataframe that contains
58-
# timestamps and entity keys. In this case it is a dataframe with two columns.
58+
# timestamps and entity keys. In this case, it is a dataframe with two columns.
5959
# One timestamp column, and one customer id column
6060
dataset = client.get_batch_features(
6161
feature_refs=features,
@@ -71,7 +71,7 @@ In the above example, Feast does a point in time correct query from a single fea
7171

7272
This is called a point in time correct join.
7373

74-
Feast allows users to retrieve features from any feature sets and join them to gether in a single response dataset. The only requirement is that the user provide the correct entities in order to look up the features.
74+
Feast allows users to retrieve features from any feature sets and join them together in a single response dataset. The only requirement is that the user provides the correct entities in order to look up the features.
7575

7676
### **Point-in-time-correct Join**
7777

@@ -81,14 +81,15 @@ Below is another example of how a point-in-time-correct join works. We have two
8181

8282
![Input 2: Driver DataFrame](https://lh3.googleusercontent.com/LRtCOzmcfhLWzpyndbRKZSVPanLLzfULoHx2YxY6N3i1gQd2Eh6MS1igahOe8ydA7zQulIFJEaQ0IXFXOsdkKRobOC6ThSOnT4hACbCl1jeM4O2JDVC_kvw8lwTCezVUD3d6ZUYj31Q)
8383

84-
Typically the `input 1` DataFrame would be provided by the user, and the `input 2` DataFrame would already be ingested into Feast. In order to join these two, the user would call Feast as follows:
84+
Typically the `input 1` DataFrame would be provided by the user, and the `input 2` DataFrame would already be ingested into Feast. To join these two, the user would call Feast as follows:
8585

8686
```python
8787
# Feature references
8888
features = [
8989
'conv_rate',
9090
'acc_rate',
9191
'avg_daily_trips',
92+
'trip_completed'
9293
]
9394

9495

@@ -124,5 +125,5 @@ data = client.get_online_features(
124125
)
125126
```
126127

127-
Online serving with Feast is built to be very low latency. Feast Serving provides a [gRPC API](https://api.docs.feast.dev/grpc/feast.serving.pb.html) that is backed by [Redis](https://redis.io/). We also provide support for [Python](https://api.docs.feast.dev/python/), [Go](https://godoc.org/github.com/gojek/feast/sdk/go), and Java clients.
128+
Online serving with Feast is built to be very low latency. Feast Serving provides a [gRPC API](https://api.docs.feast.dev/grpc/feast.serving.pb.html) that is backed by [Redis](https://redis.io/). We also provide support for [Python](https://api.docs.feast.dev/python/), [Go](https://godoc.org/github.com/gojek/feast/sdk/go), and Java clients.
128129

0 commit comments

Comments
 (0)