Skip to content

Commit ec41653

Browse files
judahrandjudahrand
authored
Remove untested and undocumented interfaces (#2084)
* Remove `FeatureTable` class from Python SDK Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com> * Remove `FeatureRef` class from Python SDK Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com> * Remove out of date concepts documentation Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
1 parent 15fcb40 commit ec41653

27 files changed

+76
-1113
lines changed

‎docs/concepts/architecture.md‎

Lines changed: 0 additions & 33 deletions
This file was deleted.

‎docs/concepts/entities.md‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎docs/concepts/feature-tables.md‎

Lines changed: 0 additions & 122 deletions
This file was deleted.

‎docs/concepts/feature-views.md‎

Lines changed: 0 additions & 123 deletions
This file was deleted.

‎docs/concepts/glossary.md‎

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎docs/concepts/sources.md‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎docs/concepts/stores.md‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

‎sdk/python/feast/__init__.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from .feature import Feature
1212
from .feature_service import FeatureService
1313
from .feature_store import FeatureStore
14-
from .feature_table import FeatureTable
1514
from .feature_view import FeatureView
1615
from .on_demand_feature_view import OnDemandFeatureView
1716
from .repo_config import RepoConfig
@@ -36,7 +35,6 @@
3635
"Feature",
3736
"FeatureService",
3837
"FeatureStore",
39-
"FeatureTable",
4038
"FeatureView",
4139
"OnDemandFeatureView",
4240
"RepoConfig",

‎sdk/python/feast/data_source.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ def date_partition_column(self, date_partition_column):
331331
@abstractmethod
332332
def from_proto(data_source: DataSourceProto) -> Any:
333333
"""
334-
Converts data source config in FeatureTable spec to a DataSource class object.
334+
Converts data source config in protobuf spec to a DataSource class object.
335335
336336
Args:
337337
data_source: A protobuf representation of a DataSource.

‎sdk/python/feast/diff/FcoDiff.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from feast.base_feature_view import BaseFeatureView
66
from feast.entity import Entity
77
from feast.feature_service import FeatureService
8-
from feast.feature_table import FeatureTable
98
from feast.protos.feast.core.Entity_pb2 import Entity as EntityProto
109
from feast.protos.feast.core.FeatureView_pb2 import FeatureView as FeatureViewProto
1110

@@ -44,7 +43,7 @@ def add_fco_diff(self, fco_diff: FcoDiff):
4443
self.fco_diffs.append(fco_diff)
4544

4645

47-
T = TypeVar("T", Entity, BaseFeatureView, FeatureService, FeatureTable)
46+
T = TypeVar("T", Entity, BaseFeatureView, FeatureService)
4847

4948

5049
def tag_objects_for_keep_delete_add(

0 commit comments

Comments
 (0)