resolve comments

Anarion-zuo · ntkathole · commit ea6358fda9fe · 2026-04-05T20:22:38.000+05:30
Signed-off-by: aaronzuo &lt;anarionzuo@outlook.com&gt;
diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml
@@ -159,7 +159,7 @@ jobs:
             -H "mcp-protocol-version: 2025-03-26" \
             -H "mcp-session-id: ${SESSION_ID}" \
             --data '{}' \
-            http://127.0.0.1:6566/mcp || true
+            http://127.0.0.1:6566/mcp
 
           grep -Eq "^HTTP/.* 400" /tmp/mcp_headers2
           grep -Eiq "^content-type: application/json" /tmp/mcp_headers2
diff --git a/sdk/python/feast/infra/mcp_servers/mcp_server.py b/sdk/python/feast/infra/mcp_servers/mcp_server.py
@@ -44,7 +44,7 @@ def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastAp
             description="Feast Feature Store MCP Server - Access feature store data and operations through MCP",
         )
 
-        transport = getattr(config, "mcp_transport", "sse") or "sse"
+        transport = getattr(config, "mcp_transport", "sse")
         if transport == "http":
             mount_http = getattr(mcp, "mount_http", None)
             if mount_http is None:
@@ -63,6 +63,7 @@ def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastAp
                 )
                 mcp.mount()
         else:
+            # Defensive guard for programmatic callers.
             raise McpTransportNotSupportedError(
                 f"Unsupported mcp_transport={transport!r}. Expected 'sse' or 'http'."
             )

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastAp`
`44`	`44`	`description="Feast Feature Store MCP Server - Access feature store data and operations through MCP",`
`45`	`45`	`)`
`46`	`46`
`47`		`- transport = getattr(config, "mcp_transport", "sse") or "sse"`
	`47`	`+ transport = getattr(config, "mcp_transport", "sse")`
`48`	`48`	`if transport == "http":`
`49`	`49`	`mount_http = getattr(mcp, "mount_http", None)`
`50`	`50`	`if mount_http is None:`
`@@ -63,6 +63,7 @@ def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastAp`
`63`	`63`	`)`
`64`	`64`	`mcp.mount()`
`65`	`65`	`else:`
	`66`	`+ # Defensive guard for programmatic callers.`
`66`	`67`	`raise McpTransportNotSupportedError(`
`67`	`68`	`f"Unsupported mcp_transport={transport!r}. Expected 'sse' or 'http'."`
`68`	`69`	`)`