fix - ensure on demand feature views can be checked too

astronautas · astronautas · commit e637eac8d2c8 · 2025-11-11T17:15:02.000+02:00
Signed-off-by: lukas.valatka &lt;lukas.valatka@cast.ai&gt;
diff --git a/sdk/python/feast/feature_server.py b/sdk/python/feast/feature_server.py
@@ -344,18 +344,26 @@ async def push(request: PushFeaturesRequest) -> None:
     async def _get_feast_object(
         feature_view_name: str, allow_registry_cache: bool
     ) -> FeastObject:
-        try:
-            return await run_in_threadpool(
-                store.get_stream_feature_view,
-                feature_view_name,
-                allow_registry_cache=allow_registry_cache,
-            )
-        except FeatureViewNotFoundException:
-            return await run_in_threadpool(
-                store.get_feature_view,
-                feature_view_name,
-                allow_registry_cache=allow_registry_cache,
-            )
+        # FIXME: this logic repeated at least 3 times in the codebase - should be centralized
+        # in logging, in server and in feature_store (Python SDK)
+        potential_sources = [
+            store.get_feature_view,
+            store.get_on_demand_feature_view,
+            store.get_stream_feature_view,
+        ]
+
+        for source in potential_sources:
+            try:
+                return await run_in_threadpool(
+                    source,
+                    feature_view_name,
+                    allow_registry_cache=allow_registry_cache,
+                )
+            except FeatureViewNotFoundException:
+                continue
+
+        # By this point, none of the sources found the feature view
+        raise FeatureViewNotFoundException(feature_view_name)
 
     @app.post("/write-to-online-store", dependencies=[Depends(inject_user_details)])
     async def write_to_online_store(request: WriteToFeatureStoreRequest) -> None:
